From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KT1aY-0004aD-Jt
	for mharc-grub-devel@gnu.org; Tue, 12 Aug 2008 17:39:34 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KT1aW-0004ZR-CX
	for grub-devel@gnu.org; Tue, 12 Aug 2008 17:39:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KT1aU-0004Z3-Sz
	for grub-devel@gnu.org; Tue, 12 Aug 2008 17:39:31 -0400
Received: from [199.232.76.173] (port=56472 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KT1aU-0004Z0-OA
	for grub-devel@gnu.org; Tue, 12 Aug 2008 17:39:30 -0400
Received: from smtp-vbr16.xs4all.nl ([194.109.24.36]:1169)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mgerards@xs4all.nl>) id 1KT1aT-0000Zy-N1
	for grub-devel@gnu.org; Tue, 12 Aug 2008 17:39:30 -0400
Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net
	[145.99.174.249])
	by smtp-vbr16.xs4all.nl (8.13.8/8.13.8) with ESMTP id m7CLdPYF087597
	for <grub-devel@gnu.org>; Tue, 12 Aug 2008 23:39:26 +0200 (CEST)
	(envelope-from mgerards@xs4all.nl)
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <1218558487.19045.8.camel@fz.local>
	<1218558734.19045.10.camel@fz.local>
Mail-Copies-To: mgerards@xs4all.nl
Date: Tue, 12 Aug 2008 23:42:58 +0200
In-Reply-To: <1218558734.19045.10.camel@fz.local> (Felix Zielcke's message of
	"Tue, 12 Aug 2008 18:32:14 +0200")
Message-ID: <87fxp9di59.fsf@xs4all.nl>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by XS4ALL Virus Scanner
X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9
Subject: Re: [PATCH] kern/err.c + disk/raid.c error handling fixes
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Aug 2008 21:39:32 -0000

Felix Zielcke <fzielcke@z-51.de> writes:

> Am Dienstag, den 12.08.2008, 18:28 +0200 schrieb Felix Zielcke:
>
> Ok naming the old patch kern_err.diff and the new one raid_err.diff
> isn't a good idea :(
>
>
> 2008-08-12  Felix Zielcke <fzielcke@z-51.de>
>   
>         * kern/err.c [GRUB_UTIL]: Include <stdio.h>.

Please don't do this.  Why do you want this?

>           [GRUB_UTIL] (grub_print_error): Use fprintf (stderr, ...) instead of   
>           grub_printf.

Why?

It would be better to make a util/misc.c:grub_print_error instead of this

>         * disk/raid.c (GRUB_MOD_INIT): Use grub_print_error() to show RAID 
>         errors and reset grub_errno. Do not give errors to the upper layer.

"...reset grub_errno.  Do not..."
(double space)

> Index: disk/raid.c
> ===================================================================
> --- disk/raid.c	(revision 1800)
> +++ disk/raid.c	(working copy)
> @@ -581,6 +581,8 @@
>  {

Please use -up for diff, you can use:
$ svn diff --diff-cmd diff -x -up

>    grub_device_iterate (&grub_raid_scan_device);
>    grub_disk_dev_register (&grub_raid_dev);
> +  grub_print_error ();
> +  grub_errno = GRUB_ERR_NONE;
>  }
>  
>  GRUB_MOD_FINI(raid)