From: Johannes Weiner <hannes@saeurebad.de>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Jeff Garzik <jeff@garzik.org>, Tejun Heo <htejun@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: [BUG ?] kmalloc() with GFP_KERNEL while holding spinlock ?
Date: Thu, 29 May 2008 05:59:03 +0200 [thread overview]
Message-ID: <87fxs1rcag.fsf@saeurebad.de> (raw)
In-Reply-To: <483E2156.9020108@cn.fujitsu.com> (Li Zefan's message of "Thu, 29 May 2008 11:21:58 +0800")
Hi,
Li Zefan <lizf@cn.fujitsu.com> writes:
> I noticed the following issue in the code:
>
> in drivers/ata/libata-acpi.c:
>
> static void ata_acpi_handle_hotplug(struct ata_port *ap, struct ata_device *dev,
> u32 event)
> {
> ...
> spin_lock_irqsave(ap->lock, flags);
> ...
>
> if (dev) {
> if (dev->sdev)
> kobj = &dev->sdev->sdev_gendev.kobj;
> } else
> kobj = &ap->dev->kobj;
>
> if (kobj) {
> sprintf(event_string, "BAY_EVENT=%d", event);
> kobject_uevent_env(kobj, KOBJ_CHANGE, envp);
> }
>
> spin_unlock_irqrestore(ap->lock, flags);
> ...
> }
>
> and kobject_uevent_env() calls kzalloc(..., GFP_KERNEL);
Fixed by commit ae6c23c4e1ec9720b99e1e6850fe47c6c7fddbb3 "Fixups to ATA
ACPI hotplug" by Matthew Garrett.
Hannes
next prev parent reply other threads:[~2008-05-29 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 3:21 [BUG ?] kmalloc() with GFP_KERNEL while holding spinlock ? Li Zefan
2008-05-29 3:59 ` Johannes Weiner [this message]
2008-05-29 4:29 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxs1rcag.fsf@saeurebad.de \
--to=hannes@saeurebad.de \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.