From: Andi Kleen <andi@firstfloor.org>
To: Hubert Verstraete <hubskml@free.fr>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] XFS tuning on software RAID5 partitionable array; error in xfsprogs 2.9.8
Date: Fri, 16 May 2008 13:30:15 +0200 [thread overview]
Message-ID: <87fxsi32rc.fsf@basil.nowhere.org> (raw)
In-Reply-To: <482D6388.7040602@free.fr> (Hubert Verstraete's message of "Fri, 16 May 2008 12:35:52 +0200")
Hubert Verstraete <hubskml@free.fr> writes:
>
> The line 89 in libdisk/md.c is: "free(dfile2);" but it should have
> remained "if (dfile2) free(dfile2);" because dfile2 is null in case
> mkfs.xfs is run on an MD device.
ISO-C free() is defined to do nothing on a NULL input.
-Andi
next prev parent reply other threads:[~2008-05-16 11:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 10:46 MDP major registration Hubert Verstraete
2008-03-25 5:37 ` Neil Brown
2008-03-25 16:57 ` Hubert Verstraete
2008-03-26 6:52 ` Luca Berra
2008-03-26 15:54 ` Bill Davidsen
2008-03-26 17:50 ` Hubert Verstraete
2008-03-26 18:45 ` [PATCH] XFS tuning on software RAID5 partitionable array; was: " Hubert Verstraete
2008-05-16 10:35 ` [PATCH] XFS tuning on software RAID5 partitionable array; error in xfsprogs 2.9.8 Hubert Verstraete
2008-05-16 11:30 ` Andi Kleen [this message]
2008-03-26 19:18 ` MDP major registration Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxsi32rc.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=hubskml@free.fr \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.