From: Robert Jarzmik <rjarzmik@free.fr>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: dbrownell@users.sourceforge.net, linux-usb@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH ?] usb/gadget/pxa27x_udc: test ep0state == IN_DATA_STAGE rather than non-bool USB_DIR_IN
Date: 14 May 2008 21:12:38 +0200 [thread overview]
Message-ID: <87fxsksnrt.fsf@free.fr> (raw)
In-Reply-To: <482ABF15.8090006@gmail.com>
Roel Kluin <roel.kluin@gmail.com> writes:
> drivers/usb/gadget/pxa27x_udc.c uses USB_DIR_IN as if boolean in functions
> inc_ep_stats_{reqs,bytes}, lines 763, 795, 933, 985, 1037 and 1074, but
> USB_DIR_IN is defined 0x80.
Yes, USB_DIR_IN could be considered as a boolean (0x80 => true, 0x0 =>
false). I'm pretty sure it's correct.
> handle_ep0_ctrl_req() tests USB_DIR_IN bitwise and pxa_udc's ep0_state is set
> IN_DATA_STAGE or OUT_DATA_STAGE. so ep->dev->ep0state == IN_DATA_STAGE should be
> tested rather than USB_DIR_IN
No, I don't agree. Have you checked the USB 2.0 spec, especially on control
endpoint handling and control requests ?
Sorry Roel, I can't ack this patch.
--
Robert
prev parent reply other threads:[~2008-05-14 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 10:29 [PATCH ?] usb/gadget/pxa27x_udc: test ep0state == IN_DATA_STAGE rather than non-bool USB_DIR_IN Roel Kluin
2008-05-14 19:12 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxsksnrt.fsf@free.fr \
--to=rjarzmik@free.fr \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.