All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@mvista.com>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: Len Brown <lenb@kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [linux-pm] [PATCH] CPUidle: compile fix for non-x86
Date: Thu, 31 Jan 2008 12:05:30 -0800	[thread overview]
Message-ID: <87fxwd92wl.fsf@paris.hilman.org> (raw)
In-Reply-To: <924EFEDD5F540B4284297C4DC59F3DEE7202F5@orsmsx423.amr.corp.intel.com> (Venkatesh Pallipadi's message of "Thu\, 31 Jan 2008 11\:15\:29 -0800")

[Updated patch pased on suggestions from Venkatesh.]

Convert cpu_idle_wait() to cpuidle_kick_cpus() macro which is
SMP-only, and gives error on non supported CPU.

Signed-off-by: Kevin Hilman <khilman@mvista.com>

diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index d2fabe7..762d878 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -18,6 +18,14 @@
 
 #include "cpuidle.h"
 
+#if !defined(CONFIG_SMP)
+#define cpuidle_kick_cpus()	do { } while (0)
+#elif defined(CONFIG_X86)
+#define cpuidle_kick_cpus()	cpu_idle_wait()
+#else
+#error "Arch needs cpu_idle_wait() equivalent here"
+#endif
+
 DEFINE_PER_CPU(struct cpuidle_device *, cpuidle_devices);
 
 DEFINE_MUTEX(cpuidle_lock);
@@ -82,7 +90,7 @@ void cpuidle_uninstall_idle_handler(void)
 {
 	if (enabled_devices && (pm_idle != pm_idle_old)) {
 		pm_idle = pm_idle_old;
-		cpu_idle_wait();
+		cpuidle_kick_cpus();
 	}
 }
 

  reply	other threads:[~2008-01-31 20:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 10:16 Fwd: [linux-pm] [PATCH] CPUidle: compile fix for non-x86 Rafael J. Wysocki
2008-01-31 18:44 ` Pallipadi, Venkatesh
2008-01-31 18:51   ` Kevin Hilman
2008-01-31 19:15     ` Pallipadi, Venkatesh
2008-01-31 20:05       ` Kevin Hilman [this message]
2008-01-31 20:11         ` Pallipadi, Venkatesh
2008-01-31 20:26         ` Rafael J. Wysocki
2008-01-31 20:45           ` Kevin Hilman
2008-01-31 21:03             ` Rafael J. Wysocki
2008-01-31 21:33               ` Kevin Hilman
2008-02-01  0:25                 ` Pallipadi, Venkatesh
2008-02-01  1:17                   ` Rafael J. Wysocki
2008-02-01  1:28                   ` Kevin Hilman
2008-02-01  1:40                     ` Rafael J. Wysocki
2008-02-01  3:40                       ` Len Brown
2008-02-09  1:05                         ` Venki Pallipadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fxwd92wl.fsf@paris.hilman.org \
    --to=khilman@mvista.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.