From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHdos-0004CN-Cs for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 06:31:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHdoq-00048R-Qs for grub-devel@gnu.org; Wed, 23 Jan 2008 06:31:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHdop-000478-Vw for grub-devel@gnu.org; Wed, 23 Jan 2008 06:31:00 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHdop-00046z-SY for grub-devel@gnu.org; Wed, 23 Jan 2008 06:30:59 -0500 Received: from smtp-vbr11.xs4all.nl ([194.109.24.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JHdoo-0008Qs-NK for grub-devel@gnu.org; Wed, 23 Jan 2008 06:30:59 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr11.xs4all.nl (8.13.8/8.13.8) with ESMTP id m0NBUvU9066335 for ; Wed, 23 Jan 2008 12:30:57 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080123104737.GA24943@thorin> <87wsq0reod.fsf@xs4all.nl> <20080123111822.GC25594@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Wed, 23 Jan 2008 12:32:14 +0100 In-Reply-To: <20080123111822.GC25594@thorin> (Robert Millan's message of "Wed, 23 Jan 2008 12:18:22 +0100") Message-ID: <87fxword4x.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] use at_keyboard.c on i386-ieee1275 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 11:31:01 -0000 Robert Millan writes: > On Wed, Jan 23, 2008 at 11:58:58AM +0100, Marco Gerards wrote: >> Robert Millan writes: >> >> > Taking into account that ofconsole on i386: >> > >> > - Has bugs with similar usability effect than at_keyboard.c (e.g. arrow keys >> > not working). >> > - In practice doesn't provide support for any keyboard other than AT >> > (since OFW shuts down USB before transfering control to us). >> > - Sharing code with other ports (CoreBoot, attow) is more efficient to get >> > these bugs solved. >> > >> > I propose to use at_keyboard.c as default for i386-ieee1275. >> >> Fine for me, it is your baby :-) Although you forgot the changelog entry. > > * conf/i386-ieee1275.rmk (kernel_elf_SOURCES): Add > `term/i386/pc/at_keyboard.c'. > > * include/grub/i386/ieee1275/console.h: Add `'. Remove > `'. > (grub_keyboard_controller_init): New function prototype. > (grub_console_checkkey): Likewise. > (grub_console_getkey): Likewise. > > * kern/powerpc/ieee1275/init.c (grub_machine_init): Initialize AT > keyboard on i386. > > * term/ieee1275/ofconsole.c (grub_ofconsole_term): On i386, use > grub_ofconsole_checkkey() and grub_ofconsole_getkey() for input. Looks fine to me. >> Will you fix the ifdef's soon? > > My plan is to propose a split of terminal handling in kernel so that input and > output terminals become different objects. This would fix this hack and others > (such as intermangled at_keyboard.c/vga_text.c with console.c in CB port, or > gfxterm depending on grub_console_{get,check}key() ). Great! > But I'd like to leave this for later. As mentioned on IRC, Debian is planning > to start stabilizing next release in March. If GRUB 2 is mostly in shape at > that time, we'll be able to use it as the default bootloader. That's a good idea. > Which reminds me, is 1.96 coming soon? When lvm/raid, reiserfs and powerpc > issues are fixed, it might be a good time. What do you think? Fine for me, we didn't have a release for quite a while. To be honest, I just hate the upload procedure of ftp://alpha.gnu.org. The documents can be interpreted in two ways, or my English simply sucks. That's one reason for me not to release that quickly. ;-) >> Doesn't this cause any problems? Now there are two keyboard drivers >> active. > > Not at all. I didn't bother #ifdefing grub_ofconsole_{get,check}key out to > avoid cluttering it (since space is not critical), but it works fine here. Ok! > The only drawback is that it doesn't automaticaly switch to serial tty when > OFW is running there, but that's a problem for every other port anyway (I > have a solution in mind as well; when we redesign terminal handling, we > could layout a scheme in which multiple input or output terminals can be > active at the same time). Yes, that would be nice! :-) -- Marco