Re: [PATCH] Update emacs indentation instructions.

[Johannes Weiner <hannes@saeurebad.de>]

Hi,

David Brown <lkml@davidb.org> writes:

> +Fortunately, modern versions of GNU emacs support different indentation
> +styles.  If you want to use the Linux kernel style for all C code, place
> +the following in your .emacs file:
> +
> +(setq c-default-style "linux")

This variable is not defined when emacs starts up.  Best is to always
use a hook.

So I'd suggest either

	(add-hook 'c-mode-hook (lambda () (c-set-style "linux")))

or for the conditional case

	(add-hook 'c-mode-hook
                  (lambda ()
                    (c-set-style
                      (or (and (string-match "/usr/src/linux"
                                             (or (buffer-file-name) ""))
                               "linux")
                          "free-group-style"))))

Perhaps the logic could be a bit more readable :-)

Other than that, good idea to finally remove this ugly recommendation!

	Hannes