From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1JE70E-0000De-TN
	for mharc-grub-devel@gnu.org; Sun, 13 Jan 2008 12:52:11 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JE70C-0000Ck-Ue
	for grub-devel@gnu.org; Sun, 13 Jan 2008 12:52:08 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JE70B-0000CT-IJ
	for grub-devel@gnu.org; Sun, 13 Jan 2008 12:52:08 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JE70B-0000CQ-7S
	for grub-devel@gnu.org; Sun, 13 Jan 2008 12:52:07 -0500
Received: from smtp-vbr1.xs4all.nl ([194.109.24.21])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mgerards@xs4all.nl>) id 1JE70A-0001hm-Nh
	for grub-devel@gnu.org; Sun, 13 Jan 2008 12:52:06 -0500
Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net
	[145.99.174.249])
	by smtp-vbr1.xs4all.nl (8.13.8/8.13.8) with ESMTP id m0DHq20A037008
	for <grub-devel@gnu.org>; Sun, 13 Jan 2008 18:52:03 +0100 (CET)
	(envelope-from mgerards@xs4all.nl)
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <4735CDA9.4060501@t-online.de>
Mail-Copies-To: mgerards@xs4all.nl
Date: Sun, 13 Jan 2008 18:52:53 +0100
In-Reply-To: <4735CDA9.4060501@t-online.de> (Christian Franke's message of
	"Sat, 10 Nov 2007 16:26:33 +0100")
Message-ID: <87fxx1hatm.fsf@xs4all.nl>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by XS4ALL Virus Scanner
X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9
Subject: Re: [PATCH] Use getopt_long() instead of argp_parse() in grub-emu
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jan 2008 17:52:09 -0000

Christian Franke <Christian.Franke@t-online.de> writes:

> Unlike the other GRUB2 utils, grub-emu uses the glibc extension
> argp_parse(). It is unavailable on Cygwin, which might also be the
> case for other platforms where glibc is not the native runtime.
>
> This patch changes this back to the more traditional getopt_long().
>
> It also fixes the syntax of the path prefix.

There where no objections, so I'll review this patch as promised.

How did you change the path syntax?

> 2007-11-10  Christian Franke  <franke@computer.org>
>
> 	* util/grub-emu.c: Replace argp.h by getopt.h.

Please use <argp.h> and <getopt.h> to show where it comes from.

> 	(parse_opt): Remove.

You also modified options, removed struct arguments, argp and perhaps
other things I missed.  You should document them properly in the
changelog entry.

> 	(usage): New function.
> 	(main): Replace argp_parse() by getopt_long().
> 	Rename argument variables accordingly.
> 	Add missing "(...)" for root_dev in prefix.

--
Marco