From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EXojf-0004TC-LE for mharc-grub-devel@gnu.org; Thu, 03 Nov 2005 18:43:11 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EXoje-0004T7-H6 for grub-devel@gnu.org; Thu, 03 Nov 2005 18:43:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EXojc-0004SR-TO for grub-devel@gnu.org; Thu, 03 Nov 2005 18:43:10 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EXojc-0004SN-PC for grub-devel@gnu.org; Thu, 03 Nov 2005 18:43:08 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EXojc-0006DO-Qt for grub-devel@gnu.org; Thu, 03 Nov 2005 18:43:09 -0500 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 644B48D75 for ; Fri, 4 Nov 2005 00:43:07 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 04612-05 for ; Fri, 4 Nov 2005 00:43:06 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 880C28DB2 for ; Fri, 4 Nov 2005 00:43:06 +0100 (CET) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 4B3E2C047 for ; Fri, 4 Nov 2005 00:43:06 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20051103221542.GA28731@ca-server1.us.oracle.com> <87vez9xsin.fsf@student.han.nl> <20051103231920.GB28731@ca-server1.us.oracle.com> From: Marco Gerards Date: Fri, 04 Nov 2005 00:43:08 +0100 In-Reply-To: <20051103231920.GB28731@ca-server1.us.oracle.com> (Mark Fasheh's message of "Thu, 3 Nov 2005 15:19:20 -0800") Message-ID: <87fyqdxppv.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: OCFS2 support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2005 23:43:10 -0000 Mark Fasheh writes: > Hi, > On Thu, Nov 03, 2005 at 11:42:40PM +0100, Marco Gerards wrote: >> A consistent coding style is quite important for us. Would it be a >> problem for you to have a look at the GCS and make the required >> changes to your code? If you need any help, pointers, etc. I am more >> than willing to help. > Yeah no problem at all. If you don't mind, it'd help alot if you could point > out the problems - I thought I was being very thorough but clearly I was > wrong :) > > Basically with respect to coding style I copied what I saw in ext2.c / > xfs.c. Also, I set the emacs c-style to 'gnu'. > > Maybe there's a .indent file or something I could run it through? I think GNU indent defaults to the GCS. The GCS is a bit more than just indentation, for example it also says stuff about naming variables, the maximum line lengths, how comments are formatted, etc. >> A more important issue is the copyright. For GRUB 2 all copyrights >> are assigned to the FSF. Would it be possible to do this for your >> code as well? I assume it would mean Oracle has to agree with this. > I suspect this will be ok - my boss is contacting our legal department to > make sure. Cool. -- Marco