From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EI63s-0003Hz-Uh for mharc-grub-devel@gnu.org; Wed, 21 Sep 2005 10:59:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EI63e-0003AL-Ob for grub-devel@gnu.org; Wed, 21 Sep 2005 10:58:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EI63U-00033M-B5 for grub-devel@gnu.org; Wed, 21 Sep 2005 10:58:40 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EI63S-00031j-Li for grub-devel@gnu.org; Wed, 21 Sep 2005 10:58:38 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EI60C-0001C0-T2 for grub-devel@gnu.org; Wed, 21 Sep 2005 10:55:17 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 1E08D8418 for ; Wed, 21 Sep 2005 16:55:12 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 29422-09 for ; Wed, 21 Sep 2005 16:55:03 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id CA47C8495 for ; Wed, 21 Sep 2005 16:55:01 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 7CA10C048 for ; Wed, 21 Sep 2005 16:55:01 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <87oe6nlt7j.fsf@student.han.nl> <20050921082659.GA23629@zulo.hadrons.org> From: Marco Gerards Date: Wed, 21 Sep 2005 16:55:03 +0200 In-Reply-To: <20050921082659.GA23629@zulo.hadrons.org> (Guillem Jover's message of "Wed, 21 Sep 2005 11:26:59 +0300") Message-ID: <87fyrylbco.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: Building on the AMD64 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2005 14:58:57 -0000 Guillem Jover writes: Hi Guillem, > The grub_str* functions are taking 'char *' arguments, but in some > cases in the code they are given 'usigned char *' for example. 'char' > is not guaranteed to be signed or usigned on a given architecture, so > for strings it should not be specified. Right, but I wondered why the warning does not occur on the PC, I am just compiling a 32 bits GRUB 2. Or does someone have this same problem on the PC with gcc 4.0 and is this not related to my patch? >> 2005-09-20 Marco Gerards > > ... > >> * conf/i386-pc.rmk (COMMON_CFLAGS): Add `-m32'. >> (COMMON_LDFLAGS): New variable. >> (kernel_img_LDFLAGS): Include `COMMON_FLAGS'. >> (_chain_mod_LDFLAGS, fshelp_mod_LDFLAGS, fat_mod_LDFLAGS, > > This should end with ')'. Nice catch, thanks. :-) -- Marco