From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1CxBX8-0005Sr-1m for mharc-grub-devel@gnu.org; Fri, 04 Feb 2005 17:02:34 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CxBVU-0004rm-Ja for grub-devel@gnu.org; Fri, 04 Feb 2005 17:00:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1CxBVP-0004pf-BZ for grub-devel@gnu.org; Fri, 04 Feb 2005 17:00:48 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CxBVM-0004aS-3S for grub-devel@gnu.org; Fri, 04 Feb 2005 17:00:44 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CxB1W-0001xm-0H for grub-devel@gnu.org; Fri, 04 Feb 2005 16:29:54 -0500 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 749F48651 for ; Fri, 4 Feb 2005 22:21:41 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 29156-10 for ; Fri, 4 Feb 2005 22:21:39 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 86D788392 for ; Fri, 4 Feb 2005 22:21:39 +0100 (CET) Received: from marco.marco-g.com (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 46953C046 for ; Fri, 4 Feb 2005 22:21:39 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050204061115.GA20463@miracle> <87oef03xd3.fsf@marco.marco-g.com> <200502042143.27144.okuji@enbug.org> From: Marco Gerards Date: Fri, 04 Feb 2005 21:21:41 +0000 In-Reply-To: <200502042143.27144.okuji@enbug.org> (Yoshinori K. Okuji's message of "Fri, 4 Feb 2005 21:43:26 +0100") Message-ID: <87fz0c3tsq.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: iterate return values X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2005 22:02:32 -0000 "Yoshinori K. Okuji" writes: > On Friday 04 February 2005 21:04, Marco Gerards wrote: >> The changelog is fine for me, but please don't send it in as a patch. > > For me, it is fine to include ChangeLog entries in a patch. What is > wrong? When you apply the patch it can not be applied when the changelog was changed by another commit. >> This looks like a tab, please don't use tabs. I hope you can fix it >> if that is the case and the same for the rest of the patch, if the >> same happened there. > > Hmmh, I think I use tabs, too. Should I stop using tabs inside GRUB? In > the past, tabs were prefered, because using only spaces enlarged the > source code and the network bandwidth was extremely narrow. Nowadays, > these reasons are not effective any longer. Perhaps I am just confused. I was under the impression the GCS forces you to use spaces, but I can't find anything about it. And emacs creates tabs too when indenting. So it seems I was just very wrong. Sorry for the confusion. Thanks, Marco