From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
Ray Liu <ray.liu@airoha.com>, Mark Brown <broonie@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: airoha: Explicitly prevent continuous reads
Date: Thu, 19 Nov 2026 10:26:26 +0100 [thread overview]
Message-ID: <87h5hdf9z1.fsf@bootlin.com> (raw)
In-Reply-To: <37fc133b-a5f3-4b4d-ba2a-002239bbcebc@iopsys.eu> (Mikhail Kshevetskiy's message of "Wed, 18 Nov 2026 21:37:21 +0300")
Hi Mikhail,
On 18/11/2026 at 21:37:21 +03, Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> wrote:
> Hello Miquel,
>
> I think the patch is bad for the following reasons:
> * As I know there is no CS issue with Airoha controller. It works properly.
> * Airoha controller supports large reads (but only in PIO mode). Thus
> continuous reading may work properly. Unfortunately PIO reading several
> times slower than DMA reading.
> * DMA reading is much faster, but can't be used for continuous reading.
> Maximum transfer size is 8191 bytes.
>
> Thus for new Airoha controllers (en7523, an7581 and newer) it's better do
> not use continuous reading and read pages using DMA. Old controllers (like
> en7512) does not support DMA, so they can benefit from continuous mode
> reading.
I had understood that the problem was CS handling. Therefore, the
approach proposed here is not a good solution, let's drop that patch.
Thanks for the feedback,
Miquèl
prev parent reply other threads:[~2026-11-19 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:59 [PATCH] spi: airoha: Explicitly prevent continuous reads Miquel Raynal
2026-11-18 18:37 ` Mikhail Kshevetskiy
2026-11-19 9:26 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5hdf9z1.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=ray.liu@airoha.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.