Re: [PATCH 4/8] hw/gpio/pca9554: New abstract base "pca9554-base"

[Markus Armbruster <armbru@redhat.com>]

Mark Cave-Ayland <mark.caveayland@nutanix.com> writes:

> Well just the one :) The point I was making above was really about PCA955xState already existing in hw/gpio/pca9552.c: it seems that the common parent PCA955xState (and also parent class PCA955xClass) already exists for this family of chips, and in fact the real problem is that hw/gpio/pca9554.c doesn't make use of this.

Ah, I completely misunderstood your question!

PCA955xState is the instance struct of abstract type "pca955x" and its
concrete subtypes "pca9552", "pca9535", "pca9555".  These live in
pca9552.c.

We also have "pca9554" and "pca9536" in pca9554.c.  It's an entirely
separate implementation.  I have no idea whether this is approproate.
Do you think they should be subtypes of "pca955x", and share common
code?

If yes: I can't get us there, sorry.  All I'm trying to do in this
series is to bring back Marc-André's work I dropped.  I didn't feel like
leaving the properties non-class when I touch them anyway, so I
converted them to class properties first.  That may have been unwise :)