From: Takashi Iwai <tiwai@suse.de>
To: Yuho Choi <oss.patchbox@gmail.com>
Cc: Anton Yakovlev <anton.yakovlev@opensynergy.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
virtualization@lists.linux.dev, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v1] ALSA: virtio: reset device before deleting virtqueues
Date: Sun, 13 Sep 2026 09:12:39 +0200 [thread overview]
Message-ID: <87h5jtwro8.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260911031121.1542502-1-oss.patchbox@gmail.com>
On Fri, 11 Sep 2026 05:11:21 +0200,
Yuho Choi wrote:
>
> virtsnd_remove() and virtsnd_freeze() delete the virtqueues before
> resetting the device. del_vqs() frees the vring backing, but does not
> provide a generic device quiesce operation. In particular, modern
> virtio-pci keeps enabled queues active until the device is reset.
>
> Reset the device before deleting the virtqueues so it can no longer
> access the vring memory when that memory is released. This also covers
> probe failures after DRIVER_OK, which unwind through virtsnd_remove().
>
> Fixes: de3a9980d8c3 ("ALSA: virtio: add virtio sound driver")
> Fixes: 575483e90a32 ("ALSA: virtio: introduce device suspend/resume support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-09-13 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 3:11 [PATCH v1] ALSA: virtio: reset device before deleting virtqueues Yuho Choi
2026-09-11 3:24 ` sashiko-bot
2026-09-13 7:12 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5jtwro8.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=anton.yakovlev@opensynergy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mst@redhat.com \
--cc=oss.patchbox@gmail.com \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.