From: John Ogness <john.ogness@linutronix.de>
To: Prashant Rahul <prashantrahul23@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org
Cc: "Shuah Khan" <shuahkhan@gmail.com>,
"Prashant Rahul" <prashantrahul23@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Petr Mladek" <pmladek@suse.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Oleg Nesterov" <oleg@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ti-adc12138: fail init on calibration timeout
Date: Mon, 15 Jun 2026 14:18:33 +0206 [thread overview]
Message-ID: <87h5n4uhn2.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20260615111156.199906-1-prashantrahul23@gmail.com>
On 2026-06-15, Prashant Rahul <prashantrahul23@gmail.com> wrote:
> adc12138_init() starts device calibration and waits for the EOC
> interrupt before checking the calibration status. The wait helper
> returns -ETIMEDOUT if the interrupt does not arrive in time, but the
> init path ignores the error and continues probing the device. This could
> lead to registering the device even tho it may not be properly
> initialized.
>
> Return the wait error so probe fails cleanly when calibration does not
> complete.
After the timeout, the driver checks the status. If the calibration is
not complete, it already returns an error with the appropriate
information. I would expect that error is preferrable to a context-less
"wait eoc timeout".
John Ogness
next prev parent reply other threads:[~2026-06-15 12:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 11:09 [PATCH] iio: adc: ti-adc12138: fail init on calibration timeout Prashant Rahul
2026-06-15 12:12 ` John Ogness [this message]
2026-06-16 10:14 ` Prashant Rahul
2026-06-15 13:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5n4uhn2.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=oleg@redhat.com \
--cc=pmladek@suse.com \
--cc=prashantrahul23@gmail.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.