From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCD71CD5BAC for ; Thu, 21 May 2026 15:03:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wQ4vZ-0003NZ-Sp; Thu, 21 May 2026 11:03:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wQ4vW-0003Mg-62 for qemu-arm@nongnu.org; Thu, 21 May 2026 11:03:10 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wQ4vT-0006kO-RA for qemu-arm@nongnu.org; Thu, 21 May 2026 11:03:09 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4896c22fcbaso52598745e9.0 for ; Thu, 21 May 2026 08:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779375786; x=1779980586; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g/8TdZZLqQDwmZI+2nkbFfne172OX66KyKf4tLY3HZE=; b=nHo4qlBZVfMn9EmUunP/d/y4gE1Fq7UTmk6bOA5PRmBwe7kCl8NXCJmota0gLaSeLs /xVr91hwjy+ZgRU2l9cc2+jwW4e1dK2Tp3RsXTy0cRtGAecyGr92Ugkp4MTUseS52her LcRCdq9UXsEYU1ZrI2ad4aXubrdgArpiGDCelZUZGIT0uDI3L3fCQXp7ZRrk5bTgCc46 u0RvzI/ljSPO3rM5l1qhp35KpaUhXtkGMy0sryJPoLMNwd99FLZloJTkDuld/Bsur70K xiY0Ius7DHkotoGqR+UriHeBZtx5DxAZTtvUisjyPb+Y64NczKmbraW98IEEOCNwRSZj pWpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779375786; x=1779980586; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g/8TdZZLqQDwmZI+2nkbFfne172OX66KyKf4tLY3HZE=; b=lWdtHI0dxW4aER2zSSxF6zq/JMQXrtaoM+iu946xAbWYut5a5/Pcoc3Ab4J++6Li8v 4GubCh+AwzYFdIH0Sc5Hc1KR73jHif3myy5DWNIJorXfMf8unhYeXktUdHGroywWs2Un U1gaBy4Rv0cG3pu7Y7byb6irkhN0Tb+d3Kj+krKurZucUKEQ9XQXRKzEGkt2xuE/h3rr AW6yEQAJ57kZZWBl2f7C/Rq+R19Nf1yF88GPU2tWd5X4Pv8Y5pSGnNH6GQ4MhL/10BD6 uETv/2fsosCso6XzZXnuEwlua91CHj1Zk+8ykh/gCtnK3Ijnvm38q348QwfHDxWjjbBy HN+Q== X-Gm-Message-State: AOJu0YyH28+OWLzU71ZtGGr8lOIMCHKXp183ytzm48vLZA77qTJvUGKI zRk5Fr4esrUwE+36LXygIx6F3wsgMOx/+bhhFCEV11ZwCnU6ON0DCwd6U5Xo8pFA4U4= X-Gm-Gg: Acq92OGhWbg1aZhIEf+sT9ZLhicGSla9Hlo+n1g5pIVrhIZGBuIRtvaINzfM9co8M5r +DgJQHZAoIe44r3EdNG2nFXtjcIhJwDisC3AX6JFV2LPuHigJSDURHJwP7fXjoob6IaP8DTWaXX V3j4mHwT/st/sJm3bQfRCrHa6jxlewmQxkrDLubaSRLW6YcMWU7ApyNQhBP9oAUoS9qLvjs6RSP INQ/qzn58uW6L+9hb1kOKSJE+O0Nta/bKigZJdwimJq72a3PJJkbTOgJQaeUYynz2qQsX3WIXd3 k4PvXMEfpLSl83jxTc70NseaGsPg+3h/HQks1jv6RNO+oNZmr+s7lYAq5d4ngH4xVhyN9O3A197 OewxI2GFLTVJIwJg1CSlUDbuSs5wkz+DDfj3gk8bCXMPAFrMXUZmM9D4JVZcK5gapn3+eccyYYu AziIzgeJaWp78daAt8XiX5pTqTsTxfxwuhBg== X-Received: by 2002:a05:600c:468b:b0:488:a824:fdff with SMTP id 5b1f17b1804b1-490360c53c8mr50881125e9.22.1779375785915; Thu, 21 May 2026 08:03:05 -0700 (PDT) Received: from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4903c99cb43sm31470915e9.4.2026.05.21.08.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 08:03:05 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 61D9A5F886; Thu, 21 May 2026 16:03:04 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Peter Maydell Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org Subject: Re: [PATCH 3/3] target/arm: Set correct fp flags for FLOGB when FPCR.AH = 1 In-Reply-To: <20260521122913.1565011-4-peter.maydell@linaro.org> (Peter Maydell's message of "Thu, 21 May 2026 13:29:13 +0100") References: <20260521122913.1565011-1-peter.maydell@linaro.org> <20260521122913.1565011-4-peter.maydell@linaro.org> User-Agent: mu4e 1.14.1; emacs 30.1 Date: Thu, 21 May 2026 16:03:04 +0100 Message-ID: <87h5o0olef.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Peter Maydell writes: > Our implementation of the FLOGB insn does the operations entirely > in the helper function, without needing to use fpu functions. > This means it needs to handle all the fp status flags itself. > We aren't setting float_flag_input_denormal_used when we > use (i.e. do not flush to zero) an input denormal, which means > that FPCR.IDC isn't set when it should be for FPCR.AH=3D1. > We missed this when we added float_flag_input_denormal_used > and made the fpu/ code set it. > > Add the missing float_raise(). > > Cc: qemu-stable@nongnu.org > Fixes: d38a57a3f ("target/arm: Enable FEAT_AFP for '-cpu max'") > Signed-off-by: Peter Maydell Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro