From: Jakub Sitnicki <jakub@cloudflare.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
kernel-team@cloudflare.com
Subject: Re: [PATCH net v2] net: Clear skb metadata in LWT BPF xmit
Date: Tue, 19 May 2026 11:47:49 +0200 [thread overview]
Message-ID: <87h5o3ohmi.fsf@cloudflare.com> (raw)
In-Reply-To: <20260518161827.2ac4766f@kernel.org> (Jakub Kicinski's message of "Mon, 18 May 2026 16:18:27 -0700")
On Mon, May 18, 2026 at 04:18 PM -07, Jakub Kicinski wrote:
> On Thu, 14 May 2026 12:47:09 +0200 Jakub Sitnicki wrote:
>> + /* LWT BPF programs cannot access skb metadata but can corrupt
>> + * it with helpers that operate on skb headroom. Drop it.
>> + */
>> + skb_metadata_clear(skb);
>
> Sashiko has a point, right? Is there something in LWT which would
> prevent us from working on clones?
Totally. I've just been spread a little thin lately.
We have a bpf/selftest that uses tc act mirred that exercises this
scenario that I need to extend.
In general, anything high/med from LLMs won't go unaddressed.
prev parent reply other threads:[~2026-05-19 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 10:47 [PATCH net v2] net: Clear skb metadata in LWT BPF xmit Jakub Sitnicki
2026-05-15 0:39 ` Chris Arges
2026-05-15 10:47 ` sashiko-bot
2026-05-18 10:00 ` Daniel Borkmann
2026-05-18 23:18 ` Jakub Kicinski
2026-05-19 9:47 ` Jakub Sitnicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5o3ohmi.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.