From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Zixun LI <admin@hifiphile.com>,
Mattijs Korpershoek <mkorpershoek@kernel.org>
Cc: u-boot@lists.denx.de, Lukasz Majewski <lukma@denx.de>,
Marek Vasut <marex@denx.de>, Tom Rini <trini@konsulko.com>,
Zixun LI <zli@ogga.fr>,
Andrew Goodbody <andrew.goodbody@linaro.org>
Subject: Re: [PATCH] usb: gadget: atmel: do not disable endpoints in reset_all_endpoints()
Date: Mon, 18 May 2026 09:37:24 +0200 [thread overview]
Message-ID: <87h5o5w4ln.fsf@kernel.org> (raw)
In-Reply-To: <CA+GyqebQKevme6u+tvp1LCKAhVxsSuKo7PQq-saQOx3dTBZ5hA@mail.gmail.com>
On Wed, May 13, 2026 at 16:05, Zixun LI <admin@hifiphile.com> wrote:
> Hi Mattijs,
>
> On Wed, May 13, 2026 at 1:24 PM Mattijs Korpershoek <mkorpershoek@kernel.org>
> wrote:
>
>>
>> Also, I believe (but I may be wrong, please try it out) that we can
>> maybe remove the whole if (!ep->desc) block from usba_ep_disable() since
>> that should be handled by the enabled flag wrapper introduced by
>> commit 59310d1ecb9f ("usb: gadget: introduce 'enabled' flag in struct
>> usb_ep")
>>
>>
> I agree we can remove the whole if block but it will desync with kernel
> code.
> Do you want me to send a patch ?
I see a follow-up has been send here:
https://lore.kernel.org/all/20260515-udc_ep-v2-1-cd335b4e62e4@hifiphile.com/
That one looks good to me. I indeed prefer to stay synced with the
kernel code!
>
> Best regards,
> Zixun LI
prev parent reply other threads:[~2026-05-18 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 13:11 [PATCH] usb: gadget: atmel: do not disable endpoints in reset_all_endpoints() Zixun LI
2026-05-13 11:24 ` Mattijs Korpershoek
2026-05-13 14:05 ` Zixun LI
2026-05-18 7:37 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5o5w4ln.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=admin@hifiphile.com \
--cc=andrew.goodbody@linaro.org \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=zli@ogga.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.