Re: [PATCH v2 2/2] hw/qdev: Remove qdev_get_human_name()

[Markus Armbruster <armbru@redhat.com>]

Alessandro Ratti <alessandro@0x65c.net> writes:

> Remove qdev_get_human_name() and switch its two callers in
> hw/block/block.c to qdev_get_printable_name().
>
> qdev_get_printable_name() subsumes qdev_get_human_name(): both
> return the device ID when set and fall back to the canonical QOM
> path, but qdev_get_printable_name() also tries the bus-specific
> device path first, providing more informative output.
>
> Narrow the scope of dev_id in blk_check_size_and_read_all() to the
> blocks where it is actually used.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Alessandro Ratti <alessandro@0x65c.net>

This replaces two ways to describe a device to the user by one.  Good.

One half of the uses is unchanged.  Good.

The other half can now show a bus-specific device path instead of the
canonical QOM path.  This path can be difficult to interpret: we have
some twenty .get_dev_path() methods, and each of them can format however
it wants.  I need to guess the format to make sense of the value.  I'm
inclined to call this a regression.

To address this, please insert another patch before this one that
changes

        device <dev-path>

  to

        <bus> device <dev-path>

This removes the guesswork, and actually satisfies the claim "more
informative output".

If you have reasons to do it in a follow-up patch instead, explain them
briefly.

qdev_get_human_name() is a better name than qdev_get_printable_name().
Please consider renaming the function so we keep the better name.