From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFED4D2503A for ; Mon, 12 Jan 2026 06:41:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfBVP-0004Pw-IR; Mon, 12 Jan 2026 01:34:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfBV7-0004NA-7X for qemu-devel@nongnu.org; Mon, 12 Jan 2026 01:34:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfBV5-00005u-E5 for qemu-devel@nongnu.org; Mon, 12 Jan 2026 01:34:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768199640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q75P1n22+QMi5jBqAhtLiMFlZnAwlYYXOIc1N07Osw8=; b=ByaMDf/yPjoShktCOHCg5ZCDfENgRtUhtXl5ofWQJ21vAiOQ+KaOWb3ZhJR/C33l2+K5YP z7IWBzTXvB9zBF/GgzuLhkvP7irLm6MtzdxFMs3lL1b0/3jNDDNSJTubxZnpcMEkwEd5E6 BboAZZR1myMpoXFCRKyiVddT1tWfrDw= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-JNkWsFP5PlKlTVCfmsEEAg-1; Mon, 12 Jan 2026 01:33:58 -0500 X-MC-Unique: JNkWsFP5PlKlTVCfmsEEAg-1 X-Mimecast-MFC-AGG-ID: JNkWsFP5PlKlTVCfmsEEAg_1768199637 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 690AA1956058; Mon, 12 Jan 2026 06:33:57 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.32]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EF1D51956048; Mon, 12 Jan 2026 06:33:56 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 8393821E66C9; Mon, 12 Jan 2026 07:33:54 +0100 (CET) From: Markus Armbruster To: Richard Henderson Cc: qemu-devel@nongnu.org Subject: Re: [PATCH v2 1/7] monitor/hmp: Replace target_ulong -> vaddr in hmp_gva2gpa() In-Reply-To: (Richard Henderson's message of "Sun, 11 Jan 2026 11:07:52 +1100") References: <20251229231546.50604-1-philmd@linaro.org> <20251229231546.50604-2-philmd@linaro.org> <87v7hcd0i8.fsf@pond.sub.org> Date: Mon, 12 Jan 2026 07:33:54 +0100 Message-ID: <87h5sribl9.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Richard Henderson writes: > On 1/8/26 18:30, Markus Armbruster wrote: >> Philippe Mathieu-Daud=C3=A9 writes: >>=20 >>> cpu_get_phys_page_debug() takes a vaddr type since commit >>> 00b941e581b ("cpu: Turn cpu_get_phys_page_debug() into a CPUClass >>> hook"). >>> >>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >>> Reviewed-by: Manos Pitsidianakis >>> Reviewed-by: Dr. David Alan Gilbert >>> --- >>> monitor/hmp-cmds-target.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c >>> index e9820611466..2976f986d35 100644 >>> --- a/monitor/hmp-cmds-target.c >>> +++ b/monitor/hmp-cmds-target.c >>> @@ -301,7 +301,7 @@ void hmp_gpa2hva(Monitor *mon, const QDict *qdict) >>>=20=20=20 >>> void hmp_gva2gpa(Monitor *mon, const QDict *qdict) >>> { >>> - target_ulong addr =3D qdict_get_int(qdict, "addr"); >>> + vaddr addr =3D qdict_get_int(qdict, "addr"); >>> CPUState *cs =3D mon_get_cpu(mon); >>> hwaddr gpa; >>=20 >> if (!cs) { >> monitor_printf(mon, "No cpu\n"); >> return; >> } >>=20 >> gpa =3D cpu_get_phys_page_debug(cs, addr & TARGET_PAGE_MASK); >> if (gpa =3D=3D -1) { >> monitor_printf(mon, "Unmapped\n"); >> } else { >> monitor_printf(mon, "gpa: 0x%" HWADDR_PRIx "\n", >> gpa + (addr & ~TARGET_PAGE_MASK)); >>=20 >> Pardon my ignorant question: is HWADDR_PRIx appropriate for vaddr? > > The print argument is gpa + offset, and hpa is hwaddr. So, hwaddr must be at least as wide as vaddr?