From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: Add missing "#phy-cells" to "usb-nop-xceiv"
Date: Wed, 07 Jan 2026 17:48:25 +0100 [thread overview]
Message-ID: <87h5sxqsh2.fsf@BLaptop.bootlin.com> (raw)
In-Reply-To: <20260105194636.3188884-1-robh@kernel.org>
"Rob Herring (Arm)" <robh@kernel.org> writes:
> The "usb-nop-xceiv" binding requires "#phy-cells" property with a value
> of 0 though it is not really used. Add it where missing from Marvell
> platforms.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-3720-db.dts | 1 +
> arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 1 +
> arch/arm64/boot/dts/marvell/armada-8040-db.dts | 2 ++
> arch/arm64/boot/dts/marvell/cn9130-crb.dtsi | 2 ++
> arch/arm64/boot/dts/marvell/cn9130-db.dtsi | 2 ++
> arch/arm64/boot/dts/marvell/cn9131-db.dtsi | 1 +
> arch/arm64/boot/dts/marvell/cn9132-db.dtsi | 2 ++
> 7 files changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-db.dts b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> index bd4e61d5448e..06d4a3a93f84 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-db.dts
> @@ -41,6 +41,7 @@ exp_usb3_vbus: usb3-vbus {
>
> usb3_phy: usb3-phy {
> compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> vcc-supply = <&exp_usb3_vbus>;
> };
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index 97a180c8dcd9..e82284888b9a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -37,6 +37,7 @@ reg_usb3_vbus: usb3-vbus {
>
> usb3_phy: usb3-phy {
> compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> vcc-supply = <®_usb3_vbus>;
> };
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> index 21ecb9c12505..c7102f74d4d5 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts
> @@ -51,6 +51,7 @@ cp0_reg_usb3_1_vbus: cp0-usb3-1-vbus {
>
> cp0_usb3_0_phy: cp0-usb3-0-phy {
> compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> vcc-supply = <&cp0_reg_usb3_0_vbus>;
> };
>
> @@ -65,6 +66,7 @@ cp1_reg_usb3_0_vbus: cp1-usb3-0-vbus {
>
> cp1_usb3_0_phy: cp1-usb3-0-phy {
> compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> vcc-supply = <&cp1_reg_usb3_0_vbus>;
> };
> };
> diff --git a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
> index 5e7d6de3cdde..5689a8bdfd03 100644
> --- a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
> @@ -47,10 +47,12 @@ cp0_reg_usb3_vbus1: regulator-2 {
>
> cp0_usb3_0_phy0: usb-phy-1 {
> compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> };
>
> cp0_usb3_0_phy1: usb-phy-2 {
> compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> vcc-supply = <&cp0_reg_usb3_vbus1>;
> };
>
> diff --git a/arch/arm64/boot/dts/marvell/cn9130-db.dtsi b/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> index 3cc320f569ad..7156739aa31a 100644
> --- a/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9130-db.dtsi
> @@ -50,6 +50,7 @@ cp0_reg_usb3_vbus0: regulator-2 {
>
> cp0_usb3_0_phy0: usb-phy-1 {
> compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> vcc-supply = <&cp0_reg_usb3_vbus0>;
> };
>
> @@ -64,6 +65,7 @@ cp0_reg_usb3_vbus1: regulator-3 {
>
> cp0_usb3_0_phy1: usb-phy-2 {
> compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> vcc-supply = <&cp0_reg_usb3_vbus1>;
> };
>
> diff --git a/arch/arm64/boot/dts/marvell/cn9131-db.dtsi b/arch/arm64/boot/dts/marvell/cn9131-db.dtsi
> index 626042fce7e2..26dc91c88677 100644
> --- a/arch/arm64/boot/dts/marvell/cn9131-db.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9131-db.dtsi
> @@ -31,6 +31,7 @@ cp1_reg_usb3_vbus0: regulator-6 {
>
> cp1_usb3_0_phy0: usb-phy-3 {
> compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> vcc-supply = <&cp1_reg_usb3_vbus0>;
> };
>
> diff --git a/arch/arm64/boot/dts/marvell/cn9132-db.dtsi b/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
> index f91fc69905b8..f82d45e62753 100644
> --- a/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
> +++ b/arch/arm64/boot/dts/marvell/cn9132-db.dtsi
> @@ -28,6 +28,7 @@ cp2_reg_usb3_vbus0: regulator-7 {
>
> cp2_usb3_0_phy0: usb-phy-4 {
> compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> vcc-supply = <&cp2_reg_usb3_vbus0>;
> };
>
> @@ -42,6 +43,7 @@ cp2_reg_usb3_vbus1: regulator-8 {
>
> cp2_usb3_0_phy1: usb-phy-5 {
> compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> vcc-supply = <&cp2_reg_usb3_vbus1>;
> };
>
> --
> 2.51.0
>
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-01-07 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 19:46 [PATCH] arm64: dts: marvell: Add missing "#phy-cells" to "usb-nop-xceiv" Rob Herring (Arm)
2026-01-07 16:48 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5sxqsh2.fsf@BLaptop.bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.