From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 078FDD12D60 for ; Wed, 3 Dec 2025 14:17:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vQnfG-0007PF-DJ; Wed, 03 Dec 2025 09:17:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQnf5-0007OZ-KC for qemu-devel@nongnu.org; Wed, 03 Dec 2025 09:16:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vQnf4-0003dA-7E for qemu-devel@nongnu.org; Wed, 03 Dec 2025 09:16:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764771412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9mS+xTIk5EEfr4OJ8Z3Hr52vsSKjngPuK1jyHzQ5m+U=; b=T1hSiRiwGSs2IMIkv6IAoF/ownPuVYpa8iCVbCHsOtieFU1muCk78c3+Mf5sY3IUozgsje bfn5RtnR4ooxQyUY4oYneYgoCZ9x17e+C7LqVtH4d4Mm6ZOavp8L6hpZBxECunJKoBu442 fok5h2lIZZ4qTiM/Ifxlrp4GQ1jXelk= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-KQb_pmKcMFip9XCiw-Gz_Q-1; Wed, 03 Dec 2025 09:16:51 -0500 X-MC-Unique: KQb_pmKcMFip9XCiw-Gz_Q-1 X-Mimecast-MFC-AGG-ID: KQb_pmKcMFip9XCiw-Gz_Q_1764771410 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D9D6418001E7; Wed, 3 Dec 2025 14:16:49 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.7]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED474180028C; Wed, 3 Dec 2025 14:16:48 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6A97A21E6A27; Wed, 03 Dec 2025 15:16:46 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Cc: marcandre.lureau@redhat.com, pbonzini@redhat.com, eblake@redhat.com, berrange@redhat.com, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru, qemu-devel@nongnu.org Subject: Re: [PATCH 2/3] error-report: move real_time_iso8601() to header In-Reply-To: <20251128200536.207344-3-vsementsov@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Fri, 28 Nov 2025 23:05:34 +0300") References: <20251128200536.207344-1-vsementsov@yandex-team.ru> <20251128200536.207344-3-vsementsov@yandex-team.ru> Date: Wed, 03 Dec 2025 15:16:46 +0100 Message-ID: <87h5u7odkh.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Vladimir Sementsov-Ogievskiy writes: > To be reused in the following commit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/qemu/error-report.h | 6 ++++++ > util/error-report.c | 7 ------- > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h > index 3ae2357fda..412b705898 100644 > --- a/include/qemu/error-report.h > +++ b/include/qemu/error-report.h > @@ -74,4 +74,10 @@ extern bool message_with_timestamp; > extern bool error_with_guestname; > extern const char *error_guest_name; > > +static inline char *real_time_iso8601(void) > +{ > + g_autoptr(GDateTime) dt = g_date_time_new_now_utc(); > + return g_date_time_format_iso8601(dt); > +} > + > #endif Reasons for inline? Because the function is so small? > diff --git a/util/error-report.c b/util/error-report.c > index 1b17c11de1..20618640e8 100644 > --- a/util/error-report.c > +++ b/util/error-report.c > @@ -169,13 +169,6 @@ static void print_loc(void) > } > } > > -static char * > -real_time_iso8601(void) > -{ > - g_autoptr(GDateTime) dt = g_date_time_new_now_utc(); > - return g_date_time_format_iso8601(dt); > -} > - > /* > * Print a message to current monitor if we have one, else to stderr. > * @report_type is the type of message: error, warning or informational.