From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90EEDCA0FED for ; Tue, 26 Aug 2025 21:31:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E58810E2EF; Tue, 26 Aug 2025 21:31:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Wm2yRDCI"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB0A610E2EF for ; Tue, 26 Aug 2025 21:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756243866; x=1787779866; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=bnxhXaCJTfVxg7Wxgb/UDBcmPKsg+/KP9HCt+uEywkg=; b=Wm2yRDCItSy7Va6ckBSfejqD1S3U6wfMWKwambcCbU2K2BxGNrCM2ptM 3Yl3Q9LfvkvtowMSgNyyCA6V44apgm2YRJDkapoAmcmAYmQoQ6blqZZ94 ACh/j6PKJ1G77mKXJKITarw9rjjfDv4kngNJQ6NvqhRpiVLAAkZSJiNdZ 3jX0VzMEwLwTX3Q7/+XpvU7BmRfzz9um4O98TFUy3UCRtJI6qeUalY0co o6WhyrMT4te+hLfZ/v/3Inf1zrfFsgeEV4uQbSRdEVGVTW8PLKJkGq5Pv 36pHDkeu846ncvJEZqBJKyALxw4Kk7ewU09HGHGMbKt8BeBlcsBSpUVk9 w==; X-CSE-ConnectionGUID: 59tXWFNNQbSCMbuZxo0b1w== X-CSE-MsgGUID: venXOAIUQ4uea+NvUA8vtQ== X-IronPort-AV: E=McAfee;i="6800,10657,11531"; a="58553290" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="58553290" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2025 14:31:06 -0700 X-CSE-ConnectionGUID: KuT0EjSSSoWjuDbQkGuksQ== X-CSE-MsgGUID: D96Obz6dT82Q7jWLc8eU+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,214,1751266800"; d="scan'208";a="193337409" Received: from bhlee-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.208.192]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2025 14:31:05 -0700 Date: Tue, 26 Aug 2025 14:31:04 -0700 Message-ID: <87h5xtn52f.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Sushma Venkatesh Reddy Cc: , Subject: Re: [PATCH 1/2] lib/xe/oa: Add perf consts to support more metrics In-Reply-To: <20250826211545.17076-1-sushma.venkatesh.reddy@intel.com> References: <20250826211545.17076-1-sushma.venkatesh.reddy@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 26 Aug 2025 14:15:44 -0700, Sushma Venkatesh Reddy wrote: > > Add new metrics: SqidiTotalCount, L3BankTotalCount, L3NodeTotalCount, > GeometryPipeTotalCount, DepthPipeTotalCount and ColorPipeTotalCount Reviewed-by: Ashutosh Dixit > > Signed-off-by: Sushma Venkatesh Reddy > --- > lib/xe/oa-configs/codegen.py | 9 ++++++++- > lib/xe/xe_oa.h | 13 +++++++++++++ > 2 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/lib/xe/oa-configs/codegen.py b/lib/xe/oa-configs/codegen.py > index 8629eac6d..d3742e11b 100644 > --- a/lib/xe/oa-configs/codegen.py > +++ b/lib/xe/oa-configs/codegen.py > @@ -128,7 +128,6 @@ class Set: > return self.xml.find(path) > > > -#TODO add SqidiTotalCount, L3BankTotalCount, L3NodeTotalCount > hw_vars_mapping = { > "$EuCoresTotalCount": { 'c': "perf->devinfo.n_eus", 'desc': "The total number of execution units" }, > "$EuSlicesTotalCount": { 'c': "perf->devinfo.n_eu_slices" }, > @@ -164,6 +163,14 @@ hw_vars_mapping = { > "$ComputeEngineTotalCount": { 'c': "perf->devinfo.n_eus", 'desc': "The total number of execution units" }, > > "$CopyEngineTotalCount": { 'c': "perf->devinfo.n_eus", 'desc': "The total number of execution units" }, > + > + "$SqidiTotalCount": { 'c': "perf->devinfo.n_sq_idis", 'desc': "Total number of SQIDI units" }, > + "$L3BankTotalCount": { 'c': "perf->devinfo.l3_banks", 'desc': "Total L3 bank count" }, > + "$L3NodeTotalCount": { 'c': "perf->devinfo.n_l3_nodes", 'desc': "Total L3 node count" }, > + > + "$GeometryPipeTotalCount": { 'c': "perf->devinfo.n_geom_pipes", 'desc': "The total number of geometry pipelines" }, > + "$DepthPipeTotalCount": { 'c': "perf->devinfo.n_depth_pipes", 'desc': "The total number of depth pipelines" }, > + "$ColorPipeTotalCount": { 'c': "perf->devinfo.n_color_pipes", 'desc': "The total number of color pipelines" }, > } > > def is_hw_var(name): > diff --git a/lib/xe/xe_oa.h b/lib/xe/xe_oa.h > index 7d3d07456..020f6d058 100644 > --- a/lib/xe/xe_oa.h > +++ b/lib/xe/xe_oa.h > @@ -110,6 +110,19 @@ struct intel_xe_perf_devinfo { > /* Number of threads in one EU */ > uint64_t eu_threads_count; > > + /* Squidi Total Count */ > + uint32_t n_sq_idis; > + /* L3 Bank Count */ > + uint32_t l3_banks; > + /* Number of L3 nodes */ > + uint32_t n_l3_nodes; > + /* Number of depth pipes */ > + uint32_t n_depth_pipes; > + /* Number of geometry pipes */ > + uint32_t n_geom_pipes; > + /* Number of color pipes */ > + uint32_t n_color_pipes; > + > /** > * Maximu number of slices present on this device (can be more than > * num_slices if some slices are fused). > -- > 2.43.0 >