Re: [Buildroot] [PATCH v2] package/wcurl: new package

From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Cc: buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2] package/wcurl: new package
Date: Fri, 22 Aug 2025 13:11:45 +0300	[thread overview]
Message-ID: <87h5xzzmvy.fsf@tarshish> (raw)
In-Reply-To: <CA+TH9V=dotgxON+5qP+7oBD83c=W=Z4hCAz8_kpA3ED4NH=4uw@mail.gmail.com> (Angelo Compagnucci's message of "Thu, 21 Aug 2025 21:09:53 +0200")

Hi Algelo,

On Thu, Aug 21 2025, Angelo Compagnucci wrote:
> Il giorno gio 21 ago 2025 alle ore 20:49 Baruch Siach <baruch@tkos.co.il> ha scritto:
>
>  On Thu, Aug 21 2025, Angelo Compagnucci wrote:
>  > wcurl is a command line tool which lets you download URLs without having to
>  > remember any parameters.
>  >
>  > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>
>  [...]
>
>  > diff --git a/package/wcurl/Config.in b/package/wcurl/Config.in
>  > new file mode 100644
>  > index 0000000000..31a007b61f
>  > --- /dev/null
>  > +++ b/package/wcurl/Config.in
>  > @@ -0,0 +1,9 @@
>  > +config BR2_PACKAGE_WCURL
>  > +     bool "wcurl"
>  > +     depends on BR2_PACKAGE_LIBCURL # runtime
>  > +     depends on BR2_PACKAGE_LIBCURL_CURL # runtime
>
>  Why not 'select'?
>
>  You don't provide a comment to guide the user about these
>  dependencies. With 'select', no comment is needed.
>
> Well, libcurl has several dependencies, and therefore selecting it
> didn't sound right to me.  I mean, I want wcurl installed, wcurl
> selects libcurl which cannot be built because some dependency is not
> met, It doesn't sound right.

BR2_PACKAGE_LIBCURL needs no dependency. Over 40 packages select
BR2_PACKAGE_LIBCURL already in Buildroot.

Surely when you 'select' a package you need to propagate its 'depends'
to avoid the issue you mentioned. But in the case of BR2_PACKAGE_LIBCURL
there is no such 'depends'.

baruch

> I think this is something for the maintainers to decide, but let me
> know what you think and I'll happily respin.
>  
>  
>  baruch
>
>  > +     help
>  > +       wcurl is a small command-line tool that wraps curl for easier use
>  > +       when downloading files from the web.
>  > +
>  > +       https://curl.se/wcurl/
>  > diff --git a/package/wcurl/wcurl.hash b/package/wcurl/wcurl.hash
>  > new file mode 100644
>  > index 0000000000..b747e99502
>  > --- /dev/null
>  > +++ b/package/wcurl/wcurl.hash
>  > @@ -0,0 +1,3 @@
>  > +# sha256 locally computed
>  > +sha256  a745475f3511090685c4d000a10f4155147b75a8c7781764612a7e8f67bb6d82  wcurl-2025.05.26.tar.gz
>  > +sha256  0127bdd267b1fa65bf5a6c487c907948e0c009aa35a5949c8aed91f779d27810  LICENSE
>  > diff --git a/package/wcurl/wcurl.mk b/package/wcurl/wcurl.mk
>  > new file mode 100644
>  > index 0000000000..8499bd3e1b
>  > --- /dev/null
>  > +++ b/package/wcurl/wcurl.mk
>  > @@ -0,0 +1,16 @@
>  > +################################################################################
>  > +#
>  > +# wcurl
>  > +#
>  > +################################################################################
>  > +
>  > +WCURL_VERSION = 2025.05.26
>  > +WCURL_SITE = $(call github,curl,wcurl,v$(WCURL_VERSION))
>  > +WCURL_LICENSE = curl
>  > +WCURL_LICENSE_FILES = LICENSE
>  > +
>  > +define FOO_INSTALL_TARGET_CMDS
>  > +      $(INSTALL) -D -m 0755 $(@D)/wcurl $(TARGET_DIR)/usr/bin
>  > +endef
>  > +
>  > +$(eval $(generic-package))

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot