From: Thomas Gleixner <tglx@linutronix.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
kernel test robot <oliver.sang@intel.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] selftests/futex: Compile also on libnuma < 2.0.16
Date: Mon, 21 Jul 2025 19:22:50 +0200 [thread overview]
Message-ID: <87h5z5tq51.ffs@tglx> (raw)
In-Reply-To: <20250715095203.vVbUIvob@linutronix.de>
On Tue, Jul 15 2025 at 11:52, Sebastian Andrzej Siewior wrote:
> INCLUDES := -I../include -I../../ $(KHDR_INCLUDES)
> -CFLAGS := $(CFLAGS) -g -O2 -Wall -pthread $(INCLUDES) $(KHDR_INCLUDES)
> +CFLAGS := $(CFLAGS) -g -O2 -Wall -pthread $(INCLUDES) $(KHDR_INCLUDES) -DLIBUNMA_VER_$(LIBNUMA_TEST)=1
LIBUNMA?
> int main(int argc, char *argv[])
> {
> struct futex32_numa *futex_numa;
> - int mem_size, i;
> + int mem_size, i __maybe_unused;
Why this unused muck?
> +#ifdef LIBUNMA_VER_SUFFICIENT
> for (i = 0; i < 4; i++) {
if you can just do
for (int i = 0; ...
?
Thanks,
tglx
next prev parent reply other threads:[~2025-07-21 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 7:36 [linus:master] [selftests/futex] 0ecb4232fc: kernel-selftests.futex/functional.make.fail kernel test robot
2025-07-15 7:57 ` Sebastian Andrzej Siewior
2025-07-15 9:52 ` [PATCH] selftests/futex: Compile also on libnuma < 2.0.16 Sebastian Andrzej Siewior
2025-07-21 17:22 ` Thomas Gleixner [this message]
2025-08-18 13:54 ` [PATCH v2] " Sebastian Andrzej Siewior
2026-03-06 17:53 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5z5tq51.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=peterz@infradead.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.