From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BA0AC369B2 for ; Thu, 17 Apr 2025 16:19:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u5Rx8-0002vt-Vv; Thu, 17 Apr 2025 12:19:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5Rx7-0002sm-IN for qemu-devel@nongnu.org; Thu, 17 Apr 2025 12:19:01 -0400 Received: from smtp-out2.suse.de ([195.135.223.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u5Rx4-0005H7-PO for qemu-devel@nongnu.org; Thu, 17 Apr 2025 12:19:01 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8D83A1F443; Thu, 17 Apr 2025 16:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744906736; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qk+6IVwb+rERXrNAt9O+sD5SzHVBcuIEg5P1WNzQkCc=; b=YpXMPwEqhuvqUR+a6Z5r1yPGk0saUHyg06PruGm3jtogFQW+Yto7acyyyfNCEVdP5iLwol 03AZzAqTTu+xPa/I2UTiM/HKDKaxymcIIUguqdz91iH+naSypYvmrlvbH1tMy3KrY3bulZ uraMDeuIJnCCiTHE7J1c2z6mKgdlfJs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744906736; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qk+6IVwb+rERXrNAt9O+sD5SzHVBcuIEg5P1WNzQkCc=; b=WaqycJeK0fkz8CG+oFM5K6Oso4Al+hNEgbJMavBs/S9bGBDJH8DdMXknH1quvr1pxy2qMq nGHdWJQRcOem7TBw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YpXMPwEq; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=WaqycJeK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1744906736; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qk+6IVwb+rERXrNAt9O+sD5SzHVBcuIEg5P1WNzQkCc=; b=YpXMPwEqhuvqUR+a6Z5r1yPGk0saUHyg06PruGm3jtogFQW+Yto7acyyyfNCEVdP5iLwol 03AZzAqTTu+xPa/I2UTiM/HKDKaxymcIIUguqdz91iH+naSypYvmrlvbH1tMy3KrY3bulZ uraMDeuIJnCCiTHE7J1c2z6mKgdlfJs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1744906736; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qk+6IVwb+rERXrNAt9O+sD5SzHVBcuIEg5P1WNzQkCc=; b=WaqycJeK0fkz8CG+oFM5K6Oso4Al+hNEgbJMavBs/S9bGBDJH8DdMXknH1quvr1pxy2qMq nGHdWJQRcOem7TBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F1F35137CF; Thu, 17 Apr 2025 16:18:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id t0crK+8pAWjAdQAAD6G6ig (envelope-from ); Thu, 17 Apr 2025 16:18:55 +0000 From: Fabiano Rosas To: Nicholas Piggin , qemu-ppc@nongnu.org Cc: Nicholas Piggin , Daniel Henrique Barboza , Harsh Prateek Bora , Laurent Vivier , Paolo Bonzini , Coiby Xu , Stefan Hajnoczi , Emanuele Giuseppe Esposito , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-block@nongnu.org Subject: Re: [PATCH 4/4] tests/qtest: Enable spapr dma with linear iommu map In-Reply-To: <20250416145918.415674-5-npiggin@gmail.com> References: <20250416145918.415674-1-npiggin@gmail.com> <20250416145918.415674-5-npiggin@gmail.com> Date: Thu, 17 Apr 2025 13:18:53 -0300 Message-ID: <87h62mep76.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 8D83A1F443 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_TWELVE(0.00)[13]; FREEMAIL_TO(0.00)[gmail.com,nongnu.org]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,linux.ibm.com,redhat.com,linaro.org,nongnu.org]; DKIM_TRACE(0.00)[suse.de:+]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_RCPT(0.00)[]; MISSING_XM_UA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Received-SPF: pass client-ip=195.135.223.131; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Nicholas Piggin writes: > qtests spapr dma was broken because the iommu was not set up. > > spapr requires hypercalls to set up the iommu (TCE tables), but > there is no support for that or a side-channel to the iommu in > qtests at the moment, so add a quick workaround in QEMU to have > the spapr iommu provide a linear map to memory when running > qtests. > > The buggy msix checks can all be removed since the tests all work > now. > > Signed-off-by: Nicholas Piggin Reviewed-by: Fabiano Rosas I'm off for the next two weeks, if you're in a rush feel free to merge this. It passes all the tests I do for the qtest tree. There's a preexisting refcount bug on the ASAN build with: QTEST_QEMU_BINARY=./qemu-system-ppc64 ./tests/qtest/qos-test -r \ /ppc64/pseries/spapr-pci-host-bridge/pci-bus-spapr/pci-bus/virtio-net-pci/virtio-net/virtio-net-tests/vhost-user/connect-fail I'll report separately.