Re: [Buildroot] [PATCH] package/rauc: needs libopenssl, not libressl

From: Peter Korsgaard <peter@korsgaard.com>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org,  Heiko Thiery <heiko.thiery@gmail.com>,
	 Andrey Yurovsky <yurovsky@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/rauc: needs libopenssl, not libressl
Date: Sun, 16 Mar 2025 20:44:55 +0100	[thread overview]
Message-ID: <87h63s4v60.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <d3fa638db3bf0ad03f5f9d345011c2eb@free.fr> (Julien Olivain's message of "Sun, 16 Mar 2025 11:54:35 +0100")

>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:

 > Hi Peter,
 > On 16/03/2025 08:57, Peter Korsgaard wrote:
 >> Fixes
 >> http://autobuild.buildroot.net/results/6efc1275d3aac9f0a4c000f3d0911b5a880e495d/
 >> Rauc uses X509_PURPOSE_get_by_id() since rauc-1.3 with commit
 >> 375dbb16dd94
 >> ("src/signature: add support for codesigning certificate purpose"):
 >> ../src/signature.c: In function 'signature_init':
 >> ../src/signature.c:97:13: warning: implicit declaration of function
 >> 'X509_PURPOSE_get_by_id'; did you mean 'X509_PURPOSE_get_id'?
 >> [-Wimplicit-function-declaration]
 >> 97 |         if (X509_PURPOSE_get_by_id(id) >= 0) {
 >> Which is not provided by LibreSSL:
 >> nm -D target/usr/lib/libcrypto.so | grep X509_PURPOSE_
 >> 00000000001377b0 T X509_PURPOSE_get0
 >> 0000000000137850 T X509_PURPOSE_get0_name
 >> 0000000000137860 T X509_PURPOSE_get0_sname
 >> 00000000001377d0 T X509_PURPOSE_get_by_sname
 >> 00000000001377a0 T X509_PURPOSE_get_count
 >> 0000000000137840 T X509_PURPOSE_get_id
 >> So force the use of libopenssl.
 >> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
 >> ---
 >> package/rauc/Config.in | 1 +
 >> 1 file changed, 1 insertion(+)
 >> diff --git a/package/rauc/Config.in b/package/rauc/Config.in
 >> index af0b99c36b..701ffef76b 100644
 >> --- a/package/rauc/Config.in
 >> +++ b/package/rauc/Config.in
 >> @@ -5,6 +5,7 @@ config BR2_PACKAGE_RAUC
 >> depends on BR2_USE_WCHAR # glib2
 >> select BR2_PACKAGE_LIBGLIB2
 >> select BR2_PACKAGE_OPENSSL
 >> +	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # uses
 >> X509_PURPOSE_get_by_id

 > If we force libopenssl here...

 >> # uses ENGINE_* API
 >> select BR2_PACKAGE_LIBOPENSSL_ENGINES if BR2_PACKAGE_LIBOPENSSL
 >                                               ^~~~~~~~~~~~~~~~~~~~~~~~~
 > ...should we also remove the "if" condition here?

Ahh yes, we can.

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot