All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH] drm/client: Build the tests with CONFIG_DRM_KUNIT_TEST=m
Date: Mon, 03 Mar 2025 13:03:33 +0200	[thread overview]
Message-ID: <87h64a1im2.fsf@intel.com> (raw)
In-Reply-To: <20250303094808.11860-1-ville.syrjala@linux.intel.com>

On Mon, 03 Mar 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Use IS_ENABLED() to check for CONFIG_DRM_KUNIT_TEST so
> that it picks up the modular case as well.
>
> Cc: Maxime Ripard <mripard@kernel.org>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/drm_client_modeset.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c
> index aca442c25209..27471a4eef21 100644
> --- a/drivers/gpu/drm/drm_client_modeset.c
> +++ b/drivers/gpu/drm/drm_client_modeset.c
> @@ -1268,6 +1268,6 @@ int drm_client_modeset_dpms(struct drm_client_dev *client, int mode)
>  }
>  EXPORT_SYMBOL(drm_client_modeset_dpms);
>  
> -#ifdef CONFIG_DRM_KUNIT_TEST
> +#if IS_ENABLED(CONFIG_DRM_KUNIT_TEST)
>  #include "tests/drm_client_modeset_test.c"
>  #endif

-- 
Jani Nikula, Intel

  parent reply	other threads:[~2025-03-03 11:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03  9:48 [PATCH] drm/client: Build the tests with CONFIG_DRM_KUNIT_TEST=m Ville Syrjala
2025-03-03  9:53 ` ✓ CI.Patch_applied: success for " Patchwork
2025-03-03  9:53 ` ✓ CI.checkpatch: " Patchwork
2025-03-03  9:54 ` ✓ CI.KUnit: " Patchwork
2025-03-03 10:02 ` ✗ CI.Build: failure " Patchwork
2025-03-03 12:28   ` Ville Syrjälä
2025-03-07  3:04     ` Lucas De Marchi
2025-03-03 11:03 ` Jani Nikula [this message]
2025-03-03 11:52 ` ✗ Fi.CI.BUILD: " Patchwork
2025-03-03 12:26   ` Ville Syrjälä
2025-03-03 12:06 ` [PATCH] " Maxime Ripard
2025-03-03 13:41 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h64a1im2.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mripard@kernel.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.