All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
	"Cezary Rojewski" <cezary.rojewski@intel.com>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Mark Brown" <broonie@kernel.org>,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: core: Change device numbering
Date: Tue, 11 Feb 2025 14:33:37 +0100	[thread overview]
Message-ID: <87h6508v2m.wl-tiwai@suse.de> (raw)
In-Reply-To: <d895d47a-7705-4cc5-aefc-5ea87fb79c84@perex.cz>

On Tue, 11 Feb 2025 14:30:42 +0100,
Jaroslav Kysela wrote:
> 
> On 11. 02. 25 11:53, Amadeusz Sławiński wrote:
> > On 1/31/2025 5:18 PM, Jaroslav Kysela wrote:
> >> On 31. 01. 25 13:41, Amadeusz Sławiński wrote:
> >> 
> >>> So, as I understand you want something like the following and to
> >>> differentiate cards in UCM using component?
> >> 
> >>> - card: 0
> >>>      id: avshdaudio
> >>>      name: avs_hdaudio
> >>>      longname: LENOVO-20KH006LPB-ThinkPadX1Carbon6th
> >>>      driver_name: avs_hdaudio
> >>>      mixer_name: Realtek ALC285
> >>>      components: HDA:10ec0285,17aa225c,00100002
> >> 
> >> The short name (name:) may be better like 'AVS HD-Audio' (almost all
> >> ASoC drivers suffers here), but the proposed driver_name is fine from my
> >> view.
> >> 
> > 
> > We had some more discussions, what about something like:
> > 
> > card X: HDAudio [AVS HD-Audio], device X: HDAudio Analog () []
> > card X: HDMI [AVS HDMI], device X: HDMI 1 () []
> > card X: ALC274 [AVS I2S ALC274], device X: Audio () []
> > 
> > - card: X
> >     id: HDAudio
> >     name: AVS HD-Audio
> >     longname: LENOVO-20KH006LPB-ThinkPadX1Carbon6th
> >     driver_name: avs_hdaudio
> >     mixer_name: Realtek ALC285
> >     components: HDA:10ec0285,17aa225c,00100002
> >     controls_count: 14
> > 
> > - card: X
> >     id: HDMI
> >     name: AVS HDMI
> >     longname: LENOVO-20KH006LPB-ThinkPadX1Carbon6th
> >     driver_name: avs_hdaudio
> >     mixer_name: Intel Kabylake HDMI
> >     components: HDA:8086280b,80860101,00100000
> >     controls_count: 21
> > 
> > - card: X
> >     id: ALC274
> >     name: AVS I2S ALC274
> >     longname:
> > IntelCorporation-CannonLakeClientPlatform-0.1-CannonLakeYLPDDR4RVP
> >     driver_name: avs_rt274
> >     mixer_name:
> >     components:
> >     controls_count: 17
> > 
> > it feels like it is more descriptive.
> 
> It looks much better for driver name and card (short) name. It also
> shows, how the DMI auto-generated long names are really broken and
> confusing for users.

Agreed, let's go ahead with this.


thanks,

Takashi

  reply	other threads:[~2025-02-11 15:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-27 14:44 [PATCH] ASoC: core: Change device numbering Amadeusz Sławiński
2025-01-27 14:45 ` Amadeusz Sławiński
2025-01-27 14:54   ` Jaroslav Kysela
2025-01-29  9:25     ` Cezary Rojewski
2025-01-29 14:51       ` Amadeusz Sławiński
2025-01-31  9:03         ` Jaroslav Kysela
2025-01-31 12:41           ` Amadeusz Sławiński
2025-01-31 16:18             ` Jaroslav Kysela
2025-02-11 10:53               ` Amadeusz Sławiński
2025-02-11 13:30                 ` Jaroslav Kysela
2025-02-11 13:33                   ` Takashi Iwai [this message]
2025-02-11 13:56                   ` Amadeusz Sławiński
2025-02-11 14:50                     ` Jaroslav Kysela
2025-02-11 15:12                       ` Amadeusz Sławiński
2025-02-12 13:39                         ` Jaroslav Kysela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6508v2m.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.