Re: [Buildroot] [PATCH 1/1] package/libnss-ato: new package

[Baruch Siach via buildroot <buildroot@buildroot.org>]

Hi Vincent,

On Tue, Nov 19 2024, Vincent Jardin wrote:
> Le 19 novembre 2024 18:08:03 Baruch Siach <baruch@tkos.co.il> a écrit :
>
>  Hi Vincent,
>
>  On Tue, Nov 19 2024, Vincent Jardin wrote:
>
>  On Tue, Nov 19, 2024 at 07:42:47AM UTC, Baruch Siach wrote:
>
>  I think this should depend on BR2_TOOLCHAIN_USES_GLIBC. Other C
>  libraries do not provide NSS functionality. It looks like this won't
>  even build without glibc headers.
>
>  Thanks, done within the new update.
>  https://patchwork.ozlabs.org/project/buildroot/patch/20241119163025.54898-1-vjardin@free.fr/
>
>  Thanks for the new iteration.
>
>  I guess you missed my second comment on your original patch, regarding
>  Makefile.
>
> Sorry. 
>
> Too many patches were needed to fix it. So since we just need to
> compile a c file, I did prefer not to use it. I do not understand the
> benefit of patching if it is not needed.

The .mk file comment currently says "no configure/Makefile". It should
says something like "We don't use Makefile because ...".

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot