All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: anish kumar <yesanishhere@gmail.com>,
	ohad@wizery.com, bjorn.andersson@linaro.org,
	mathieu.poirier@linaro.org
Cc: linux-remoteproc@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	anish kumar <yesanishhere@gmail.com>
Subject: Re: [PATCH 3/7] Remoteproc: Documentation: add the main index
Date: Tue, 22 Oct 2024 15:47:01 -0600	[thread overview]
Message-ID: <87h693olnu.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20241022213516.1756-4-yesanishhere@gmail.com>

anish kumar <yesanishhere@gmail.com> writes:

> Add index file so that readthedocs.io pick this file
> up and properly build the documentation site.
>
> Signed-off-by: anish kumar <yesanishhere@gmail.com>
> ---
>  Documentation/remoteproc/index.rst | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 Documentation/remoteproc/index.rst

readthedocs.io is not particularly relevant here; this change is needed
simply to make the docs build work right.

Properly, you should have added a version of this file first, since your
series is not bisectable as organized.  For a docs change, that alone
does not merit redoing the series, though.  However...

You do need to remove the entry in Documentation/staging/index.rst, or
you will break the docs build.

Please be sure to do a proper docs build before sending a patch series
like this.

More to the point, though, why are you creating a new top-level
directory for this?  That's something I would really like to avoid.  It
looks like the existing document fits well in the driver-api manual, is
there a reason why you haven't put it there?

Thanks,

jon

  reply	other threads:[~2024-10-22 21:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 21:35 [PATCH 0/1] remoteproc documentation changes anish kumar
2024-10-22 21:35 ` [PATCH 1/7] Documentation: remoteproc: move from staging anish kumar
2024-10-22 21:35 ` [PATCH 2/7] Documentation: remoteproc: add more information anish kumar
2024-10-22 21:35 ` [PATCH 3/7] Remoteproc: Documentation: add the main index anish kumar
2024-10-22 21:47   ` Jonathan Corbet [this message]
2024-10-22 21:35 ` [PATCH 4/7] Remoteproc: Documentation: add driver api anish kumar
2024-10-22 21:35 ` [PATCH 5/7] Remoteproc: Documentation: add userspace api anish kumar
2024-10-22 21:35 ` [PATCH 6/7] MAINTAINERS: remoteproc documentation path update anish kumar
2024-10-22 21:35 ` [PATCH 7/7] rpmsg: Documentation: update the path anish kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h693olnu.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    --cc=yesanishhere@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.