From: Anna-Maria Behnsen <anna-maria@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 04/15] timers: Move *sleep*() and timeout functions into a separate file
Date: Mon, 09 Sep 2024 10:10:16 +0200 [thread overview]
Message-ID: <87h6ap1c47.fsf@somnus> (raw)
In-Reply-To: <ZtsGwgatGpFRQerw@pavilion.home>
Frederic Weisbecker <frederic@kernel.org> writes:
> Le Wed, Sep 04, 2024 at 03:04:54PM +0200, Anna-Maria Behnsen a écrit :
>> All schedule_timeout() and *sleep*() related functions are interfaces on
>> top of timer list timers and hrtimers to add a sleep to the code. As they
>> are built on top of the timer list timers and hrtimers, the [hr]timer
>> interfaces are already used except when queuing the timer in
>> schedule_timeout(). But there exists the appropriate interface add_timer()
>> which does the same job with an extra check for an already pending timer.
>>
>> Split all those functions as they are into a separate file and use
>> add_timer() instead of __mod_timer() in schedule_timeout().
>>
>> While at it fix minor formatting issues and a multi line printk function
>> call in schedule_timeout(). While at it also add not listed
>> include/linux/delay.h to the MAINTAINTERS file.
>
> I don't mind sometimes having several logical changes within a same
> patch if that makes sense but the delay is MAINTAINERS is pretty off-topic
> and should move to its own patch.
Ack. But, I was too slow to provide a v2. It's already applied in
tip. Should we change tip, or is ok for you?
Thanks,
Anna-Maria
next prev parent reply other threads:[~2024-09-09 8:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 13:04 [PATCH 00/15] timers: Cleanup delay/sleep related mess Anna-Maria Behnsen
2024-09-04 13:04 ` [PATCH 01/15] timers: Rename next_expiry_recalc() to be unique Anna-Maria Behnsen
2024-09-06 13:25 ` Frederic Weisbecker
2024-09-08 18:58 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-09-04 13:04 ` [PATCH 02/15] cpu: Use already existing usleep_range() Anna-Maria Behnsen
2024-09-06 13:27 ` Frederic Weisbecker
2024-09-08 18:58 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-09-04 13:04 ` [PATCH 03/15] Comments: Fix wrong singular form of jiffies Anna-Maria Behnsen
2024-09-05 8:42 ` Geert Uytterhoeven
2024-09-08 18:58 ` [tip: timers/core] treewide: Fix wrong singular form of jiffies in comments tip-bot2 for Anna-Maria Behnsen
2024-09-04 13:04 ` [PATCH 04/15] timers: Move *sleep*() and timeout functions into a separate file Anna-Maria Behnsen
2024-09-06 13:42 ` Frederic Weisbecker
2024-09-09 8:10 ` Anna-Maria Behnsen [this message]
2024-09-09 12:11 ` Thomas Gleixner
2024-09-08 18:58 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-09-04 13:04 ` [PATCH 05/15] timers: Rename sleep_idle_range() to sleep_range_idle() Anna-Maria Behnsen
2024-09-06 13:45 ` Frederic Weisbecker
2024-09-06 16:25 ` SeongJae Park
2024-09-08 18:58 ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2024-09-04 13:04 ` [PATCH 06/15] timers: Update function descriptions of sleep/delay related functions Anna-Maria Behnsen
2024-09-04 14:30 ` Arnd Bergmann
2024-09-05 6:59 ` Thomas Gleixner
2024-09-05 16:07 ` Thomas Gleixner
2024-09-05 19:49 ` Anna-Maria Behnsen
2024-09-04 13:04 ` [PATCH 07/15] timers: Adjust flseep() to reflect reality Anna-Maria Behnsen
2024-09-04 13:04 ` [PATCH 08/15] mm/damon/core: Use generic upper bound recommondation for usleep_range() Anna-Maria Behnsen
2024-09-06 16:31 ` SeongJae Park
2024-09-04 13:04 ` [PATCH 09/15] timers: Add a warning to usleep_range_state() for wrong order of arguments Anna-Maria Behnsen
2024-09-04 13:05 ` [PATCH 10/15] checkpatch: Remove broken sleep/delay related checks Anna-Maria Behnsen
2024-09-05 1:28 ` Joe Perches
2024-09-05 8:04 ` Anna-Maria Behnsen
2024-09-04 13:05 ` [PATCH 11/15] regulator: core: Use fsleep() to get best sleep mechanism Anna-Maria Behnsen
2024-09-04 13:28 ` Mark Brown
2024-09-05 8:24 ` Anna-Maria Behnsen
2024-09-04 13:05 ` [PATCH 12/15] iopoll/regmap/phy/snd: Fix comment referencing outdated timer documentation Anna-Maria Behnsen
2024-09-04 14:03 ` Andrew Lunn
2024-09-05 8:15 ` Anna-Maria Behnsen
2024-09-04 13:05 ` [PATCH 13/15] powerpc/rtas: Use fsleep() to minimize additional sleep duration Anna-Maria Behnsen
2024-09-05 12:24 ` Michael Ellerman
2024-09-04 13:05 ` [PATCH 14/15] media: anysee: Fix link to outdated sleep function documentation Anna-Maria Behnsen
2024-09-04 13:05 ` [PATCH 15/15] timers/Documentation: Cleanup delay/sleep documentation Anna-Maria Behnsen
2024-09-04 14:44 ` [PATCH 00/15] timers: Cleanup delay/sleep related mess Rafael J. Wysocki
2024-10-17 14:19 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6ap1c47.fsf@somnus \
--to=anna-maria@linutronix.de \
--cc=corbet@lwn.net \
--cc=frederic@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.