All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Chen Yufan <chenyufan@vivo.com>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Chen Yufan <chenyufan@vivo.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH v2] X86 architecture (32-bit and 64-bit): Convert to use jiffies macro
Date: Sun, 25 Aug 2024 13:23:53 +0200	[thread overview]
Message-ID: <87h6b8g81i.ffs@tglx> (raw)
In-Reply-To: <20240822082449.34601-1-chenyufan@vivo.com>

On Thu, Aug 22 2024 at 16:24, Chen Yufan wrote:
> Use time_after macro instead of using
> jiffies directly to handle wraparound.
>
> Signed-off-by: Chen Yufan <chenyufan@vivo.com>
>
> The modifications made compared to the previous version are as follows:

Please put such version information below the --- separator so tools can
strip it off when applying the patch, which avoids editiong

> 1. Remove extra '+' in the header.

The subject line still has a incorrect subsystem prefix:

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject

Also 'use jiffies macro' is not really informative. Something like

     "Use time_after() for jiffies comparison"

makes it entirely clear what this is about.

> Use time_after macro instead of using
> jiffies directly to handle wraparound.

Also here instead of 'time_after macro' please use simply
'time_after()'. It's uninteresting whether this is a macro or not.

Thanks,

        tglx

      reply	other threads:[~2024-08-25 11:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-22  8:24 [PATCH v2] X86 architecture (32-bit and 64-bit): Convert to use jiffies macro Chen Yufan
2024-08-25 11:23 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6b8g81i.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=bp@alien8.de \
    --cc=chenyufan@vivo.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=opensource.kernel@vivo.com \
    --cc=sfr@canb.auug.org.au \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.