From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>, Paul Menzel <pmenzel@molgen.mpg.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: testing/selftests/alsa/mixer-test: 10 failures on Dell XPS 13 9360
Date: Fri, 14 Jun 2024 13:33:10 +0200 [thread overview]
Message-ID: <87h6dv92tl.wl-tiwai@suse.de> (raw)
In-Reply-To: <c9707ade-bd43-419b-8959-0b45d572facd@sirena.org.uk>
On Mon, 03 Jun 2024 13:38:18 +0200,
Mark Brown wrote:
>
> On Fri, May 31, 2024 at 08:06:14PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
> > > On Fri, May 31, 2024 at 05:17:43PM +0200, Takashi Iwai wrote:
> > > > On Fri, 31 May 2024 07:50:33 +0200,
>
> > > I would say these are all bugs, they show the driver not correcting the
> > > value and allowing users to read back out of range values that were
> > > written. Even if the driver is accepting out of range values I'd expect
> > > it to transform them somehow when storing, the program will accept a
> > > mismatched read when testing this case but it will complain if the read
> > > value is not valid according to the control's info.
>
> > Ideally, yeah. But it's a whack-a-mole game, and my gut feeling is
> > that it'd be better to enable the input validation globally, something
> > like below.
>
> Yeah, I mean I tend to think the whole accepting invalid values thing is
> questionable to start off with so I do think that's a good idea. That
> said we probably should still be fixing the drivers as well.
OK, I'm going to submit a patch set for addressing those.
Takashi
next prev parent reply other threads:[~2024-06-14 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 5:50 testing/selftests/alsa/mixer-test: 10 failures on Dell XPS 13 9360 Paul Menzel
2024-05-31 15:17 ` Takashi Iwai
2024-05-31 15:25 ` Paul Menzel
2024-05-31 16:03 ` Mark Brown
2024-05-31 18:06 ` Takashi Iwai
2024-06-03 11:38 ` Mark Brown
2024-06-14 11:33 ` Takashi Iwai [this message]
2024-06-14 11:42 ` Jaroslav Kysela
2024-06-14 12:38 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6dv92tl.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pmenzel@molgen.mpg.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.