All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] drm/i915: use check_add_overflow() and drop local variants
Date: Tue, 09 Apr 2024 13:38:25 +0300	[thread overview]
Message-ID: <87h6ga95y6.fsf@intel.com> (raw)
In-Reply-To: <ZhPqIejwwbEppXUr@intel.com>

On Mon, 08 Apr 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Fri, Apr 05, 2024 at 11:26:25PM +0300, Jani Nikula wrote:
>> Prefer common check_add_overflow() from overflow.h over the locally
>> rolled versions of it. While check_add_overflow() does require a
>> variable to assign to, unlike add_overflows_t(), it's still better than
>> having multiple versions around.
>> 
>> Cc: Kees Cook <keescook@chromium.org>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Thanks, pushed to drm-intel-next.

BR,
Jani.


-- 
Jani Nikula, Intel

  reply	other threads:[~2024-04-09 10:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 20:26 [PATCH] drm/i915: use check_add_overflow() and drop local variants Jani Nikula
2024-04-05 20:59 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2024-04-05 21:10 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-08 12:59 ` [PATCH] " Rodrigo Vivi
2024-04-09 10:38   ` Jani Nikula [this message]
2024-04-08 17:16 ` ✗ Fi.CI.SPARSE: warning for drm/i915: use check_add_overflow() and drop local variants (rev2) Patchwork
2024-04-08 17:22 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-09  5:48 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6ga95y6.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=keescook@chromium.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.