From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ED0CC47074 for ; Tue, 2 Jan 2024 19:33:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rKkVp-0003CY-FP; Tue, 02 Jan 2024 14:33:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKkVm-0003CF-1w for qemu-devel@nongnu.org; Tue, 02 Jan 2024 14:33:14 -0500 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rKkVj-0005MS-UR for qemu-devel@nongnu.org; Tue, 02 Jan 2024 14:33:13 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 272841FD03; Tue, 2 Jan 2024 19:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704223990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jtrDlhV4SCExFZEDgoFNrM9Zs1V8RfsBWmW8qcLLwuk=; b=k72n1oXMiGUpXXKZLbFYFzqCg+ZKP/HW+UjBNE7yuEuziIwxXlXL16YXoD1hefICPGQ3Ks 2zUJki3wI0DIZbezsbqr0mYodMZ0ofNPmotJeicQGktTwr+2dh/9Rk6H27r/22mJiahSl2 waD8n/zBlVfyirdKLgsxkoYNeulagKw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704223990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jtrDlhV4SCExFZEDgoFNrM9Zs1V8RfsBWmW8qcLLwuk=; b=9QAz2WVzJwVdVi3MPTJIfkwTJ+v0VKN9ZQMjGnTMvPDY1645BgA13NAjKSyTfilCa0X5qQ j5cc4RDfgw2G/NDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704223990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jtrDlhV4SCExFZEDgoFNrM9Zs1V8RfsBWmW8qcLLwuk=; b=k72n1oXMiGUpXXKZLbFYFzqCg+ZKP/HW+UjBNE7yuEuziIwxXlXL16YXoD1hefICPGQ3Ks 2zUJki3wI0DIZbezsbqr0mYodMZ0ofNPmotJeicQGktTwr+2dh/9Rk6H27r/22mJiahSl2 waD8n/zBlVfyirdKLgsxkoYNeulagKw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704223990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jtrDlhV4SCExFZEDgoFNrM9Zs1V8RfsBWmW8qcLLwuk=; b=9QAz2WVzJwVdVi3MPTJIfkwTJ+v0VKN9ZQMjGnTMvPDY1645BgA13NAjKSyTfilCa0X5qQ j5cc4RDfgw2G/NDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A4E0A13AC6; Tue, 2 Jan 2024 19:33:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id pU4VG/VklGVALgAAD6G6ig (envelope-from ); Tue, 02 Jan 2024 19:33:09 +0000 From: Fabiano Rosas To: Avihai Horon , qemu-devel@nongnu.org Cc: Juan Quintela , Peter Xu , Leonardo Bras , Li Zhijian , Avihai Horon Subject: Re: [PATCH 08/11] migration/multifd: Remove error_setg() in migration_ioc_process_incoming() In-Reply-To: <20231231093016.14204-9-avihaih@nvidia.com> References: <20231231093016.14204-1-avihaih@nvidia.com> <20231231093016.14204-9-avihaih@nvidia.com> Date: Tue, 02 Jan 2024 16:33:07 -0300 Message-ID: <87h6jv5y4s.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=k72n1oXM; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9QAz2WVz X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.38 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-2.87)[99.45%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Queue-Id: 272841FD03 Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Avihai Horon writes: > If multifd_load_setup() fails in migration_ioc_process_incoming(), > error_setg() is called with errp. This will lead to an assert because in > that case errp already contains an error. > > Fix it by removing the redundant error_setg(). > > Fixes: 6720c2b32725 ("migration: check magic value for deciding the mapping of channels") > Signed-off-by: Avihai Horon Reviewed-by: Fabiano Rosas