From: Baruch Siach <baruch@tkos.co.il>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: stmmac: avoid rx queue overrun
Date: Tue, 14 Nov 2023 10:08:29 +0200 [thread overview]
Message-ID: <87h6lodabv.fsf@tarshish> (raw)
In-Reply-To: <20231113175222.674a3971@kernel.org>
Hi Jakub,
On Mon, Nov 13 2023, Jakub Kicinski wrote:
> On Mon, 13 Nov 2023 19:42:50 +0200 Baruch Siach wrote:
>> dma_rx_size can be set as low as 64. Rx budget might be higher than
>> that. Make sure to not overrun allocated rx buffers when budget is
>> larger.
>>
>> Leave one descriptor unused to avoid wrap around of 'dirty_rx' vs
>> 'cur_rx'.
>
> Can we get a Fixes tag for this one as well?
I believe it goes back to the commit that introduced the driver.
Fixes: 47dd7a540b8a ("net: add support for STMicroelectronics Ethernet controllers.")
Should I resend with the Fixes tag?
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2023-11-14 8:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 17:42 [PATCH net 1/2] net: stmmac: fix rx budget limit check Baruch Siach
2023-11-13 17:42 ` [PATCH net 2/2] net: stmmac: avoid rx queue overrun Baruch Siach
2023-11-13 22:52 ` Jakub Kicinski
2023-11-14 8:08 ` Baruch Siach [this message]
2023-11-14 16:04 ` Serge Semin
2023-11-14 16:09 ` Baruch Siach
2023-11-14 11:25 ` [PATCH net 1/2] net: stmmac: fix rx budget limit check Serge Semin
2023-11-15 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6lodabv.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=alexandre.torgue@foss.st.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.