From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 272EEC4332F for ; Wed, 1 Nov 2023 16:28:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4D3610E73B; Wed, 1 Nov 2023 16:28:52 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D13E10E73B for ; Wed, 1 Nov 2023 16:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698856130; x=1730392130; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=voZgE5xrdaZwvtDvhHdEZVV7aMRAibjMc0v00EHMUgk=; b=jtXDcCwoe/IFZ+qUHfAMi7hFBJJ4/xTXMF2IOu5luOVk7VqVeeKUdOp3 rKiCPE7y1GvZ9YmYH11z7+QDL6m11W1vJvnzePTGxAWf2puPZPybg0XjQ E+HEPXYFHsNbZsbuZg7mh4RTOewzSOrdD27KaA9dvrFaSBwPYruoMeYsv 2/iPQbALjj2ahj0H4YN1BNWcW16WpBnE8MKVV4y16C4R+MOVt3VdImeSN ztNT4/y2UJjRliS6unCYoMPQANuUcLYaBRCG+0BERlHn3x/LsU19Qve1H AbkIWD+Q0rkwm1Lb3m87zJTNr8cgWHs9CwHDZGdmFehLSh7nfMfl024ES A==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="373566145" X-IronPort-AV: E=Sophos;i="6.03,268,1694761200"; d="scan'208";a="373566145" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 09:28:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="754517018" X-IronPort-AV: E=Sophos;i="6.03,268,1694761200"; d="scan'208";a="754517018" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.251.29.51]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 09:28:49 -0700 Date: Wed, 01 Nov 2023 09:28:49 -0700 Message-ID: <87h6m5a14u.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Badal Nilawar In-Reply-To: <20231101163212.1629685-1-badal.nilawar@intel.com> References: <20231101163212.1629685-1-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH] drm/xe/mtl: Use 16.67 Mhz freq scale factor to get rpX X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 01 Nov 2023 09:32:12 -0700, Badal Nilawar wrote: > > For mtl and above 16.67 Mhz is the scale factor to calculate > rpX frequencies. > > v2: Fix review comment (Ashutosh) Reviewed-by: Ashutosh Dixit > > Signed-off-by: Badal Nilawar > --- > drivers/gpu/drm/xe/xe_guc_pc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c > index 74247e0d3674..020c6597cd78 100644 > --- a/drivers/gpu/drm/xe/xe_guc_pc.c > +++ b/drivers/gpu/drm/xe/xe_guc_pc.c > @@ -313,7 +313,7 @@ static void mtl_update_rpe_value(struct xe_guc_pc *pc) > else > reg = xe_mmio_read32(gt, MTL_GT_RPE_FREQUENCY); > > - pc->rpe_freq = REG_FIELD_GET(MTL_RPE_MASK, reg) * GT_FREQUENCY_MULTIPLIER; > + pc->rpe_freq = decode_freq(REG_FIELD_GET(MTL_RPE_MASK, reg)); > } > > static void tgl_update_rpe_value(struct xe_guc_pc *pc) > @@ -653,10 +653,10 @@ static void mtl_init_fused_rp_values(struct xe_guc_pc *pc) > reg = xe_mmio_read32(gt, MTL_MEDIAP_STATE_CAP); > else > reg = xe_mmio_read32(gt, MTL_RP_STATE_CAP); > - pc->rp0_freq = REG_FIELD_GET(MTL_RP0_CAP_MASK, reg) * > - GT_FREQUENCY_MULTIPLIER; > - pc->rpn_freq = REG_FIELD_GET(MTL_RPN_CAP_MASK, reg) * > - GT_FREQUENCY_MULTIPLIER; > + > + pc->rp0_freq = decode_freq(REG_FIELD_GET(MTL_RP0_CAP_MASK, reg)); > + > + pc->rpn_freq = decode_freq(REG_FIELD_GET(MTL_RPN_CAP_MASK, reg)); > } > > static void tgl_init_fused_rp_values(struct xe_guc_pc *pc) > -- > 2.25.1 >