From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFEF1E7D27D for ; Tue, 26 Sep 2023 10:54:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F3C010E39D; Tue, 26 Sep 2023 10:54:38 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A77E010E39D for ; Tue, 26 Sep 2023 10:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695725676; x=1727261676; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=g8hCUSDAx19pnnGuoAbFjYAYbS6iIL0pDAKORe079jE=; b=AbB2NsfDc0o6rReBMTLKd6rV+55sgUIINGN+sFDK+vbMas1KNQ+O/uZ+ HdeUdwkGcgmBv8E/SmgEAluCnZjS3sv43dHTerF/tuOolP30530TX9MIU c+f131yE0Yag/zB65HA1Yh+NBpAWFxBZbGZjKzTBDW5WtR5FCQnr1r0WU NsSnMQvb4ADVhQFfJYZsWh7Mn8/k2OKYzneTes98Bas4vdBNclAh1HFmQ qeWY9pOqQZOmBfwrk6DbIDPcZvEyehouz2bcgZ+tE5wOnsKkxFvwkRkvu nY1MzNZJoN+aDB+TDgHykr9UxLTsPRXxaFx+XTwDsjHbMyl7VbFZM//al w==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="381438704" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="381438704" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 03:54:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="108328" Received: from wagnert-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.52.202]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 03:54:04 -0700 From: Jani Nikula To: Uma Shankar , intel-gfx@lists.freedesktop.org In-Reply-To: <20230925065014.1252784-1-uma.shankar@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230925065014.1252784-1-uma.shankar@intel.com> Date: Tue, 26 Sep 2023 13:54:31 +0300 Message-ID: <87h6nhkxw8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [v2] drm/i915/display: Add a wrapper function for vga decode setup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 25 Sep 2023, Uma Shankar wrote: > Some of the VGA functionality is not needed by the proposed > Intel Xe driver, while this will be utilized by i915. > Adding a wrapper function for VGA decode setup. So, this duplicates intel_vga_set_decode() without removing the old one. Is that the intention? I guess the idea here is that xe doesn't build intel_gmch, so you can add a nop version there? BR, Jani. > > v2: Addressed Jani Nikula's review comments. > > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/i915/display/intel_vga.c | 2 -- > drivers/gpu/drm/i915/soc/intel_gmch.c | 14 ++++++++++++++ > drivers/gpu/drm/i915/soc/intel_gmch.h | 2 ++ > 3 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i= 915/display/intel_vga.c > index 286a0bdd28c6..0f65ce115035 100644 > --- a/drivers/gpu/drm/i915/display/intel_vga.c > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > @@ -3,11 +3,9 @@ > * Copyright =C2=A9 2019 Intel Corporation > */ >=20=20 > -#include > #include >=20=20 > #include