From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2A1CBE76 for ; Tue, 15 Aug 2023 10:39:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29BAFC433C7; Tue, 15 Aug 2023 10:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692095949; bh=Gf3HzodU8tLo1mIQprRqSUpWxSeTthPjIQL+JBRkSzg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hPCNwAeaVLW55YAcAFZ6+axIhPjbwlZxgobxFTMyN6do7wyATvRVdDZuoxfTbdcij U/5GDxxMdWjCFa6T+IBkaT0zyqGkjMFHoYdx/cPzey6gDfwz0v1nRRmHLAVIyl5swC plgYvB82cBSsn61TQPFrFQ+QjT1QikhnnF86x07dphFUajWXhrhu6+bUJlLxIxZwD6 BXjwyXV22XtL0KI5gFQ2nStq0vWGZrJbI6gAZErAOZR90+W7ObllkTUYaP+jbFPcoI XnNh+Th+gQj0ut3NMKW33E2nZP+erVTkLbiXZ/5MC+ub9PBr7FEz4STq3zQYuVmONH mcu+hGb5ydF8w== Received: from host213-123-75-60.in-addr.btopenworld.com ([213.123.75.60] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qVrS5-004ycj-VF; Tue, 15 Aug 2023 11:39:07 +0100 Date: Tue, 15 Aug 2023 11:39:18 +0100 Message-ID: <87h6p0pp2h.wl-maz@kernel.org> From: Marc Zyngier To: Jing Zhang Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Eric Auger , Mark Brown , Mark Rutland , Will Deacon , Alexandru Elisei , Andre Przywara , Chase Conklin , Ganapatrao Kulkarni , Darren Hart , Miguel Luis , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH v3 01/27] arm64: Add missing VA CMO encodings In-Reply-To: References: <20230808114711.2013842-1-maz@kernel.org> <20230808114711.2013842-2-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 213.123.75.60 X-SA-Exim-Rcpt-To: jingzhangos@google.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, eric.auger@redhat.com, broonie@kernel.org, mark.rutland@arm.com, will@kernel.org, alexandru.elisei@arm.com, andre.przywara@arm.com, chase.conklin@arm.com, gankulkarni@os.amperecomputing.com, darren@os.amperecomputing.com, miguel.luis@oracle.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 10 Aug 2023 04:14:51 +0100, Jing Zhang wrote: >=20 > Hi Marc, >=20 > On Tue, Aug 8, 2023 at 4:47=E2=80=AFAM Marc Zyngier wrot= e: > > > > Add the missing VA-based CMOs encodings. > > > > Reviewed-by: Eric Auger > > Signed-off-by: Marc Zyngier > > Reviewed-by: Miguel Luis > > Acked-by: Catalin Marinas > > Reviewed-by: Zenghui Yu > > --- > > arch/arm64/include/asm/sysreg.h | 26 ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/s= ysreg.h > > index b481935e9314..85447e68951a 100644 > > --- a/arch/arm64/include/asm/sysreg.h > > +++ b/arch/arm64/include/asm/sysreg.h > > @@ -124,6 +124,32 @@ > > #define SYS_DC_CIGSW sys_insn(1, 0, 7, 14, 4) > > #define SYS_DC_CIGDSW sys_insn(1, 0, 7, 14, 6) > > > > +#define SYS_IC_IALLUIS sys_insn(1, 0, 7, 1, 0) > > +#define SYS_IC_IALLU sys_insn(1, 0, 7, 5, 0) > > +#define SYS_IC_IVAU sys_insn(1, 3, 7, 5, 1) > > + > > +#define SYS_DC_IVAC sys_insn(1, 0, 7, 6, 1) > > +#define SYS_DC_IGVAC sys_insn(1, 0, 7, 6, 3) > > +#define SYS_DC_IGDVAC sys_insn(1, 0, 7, 6, 5) > > + > > +#define SYS_DC_CVAC sys_insn(1, 3, 7, 10, 1) > > +#define SYS_DC_CGVAC sys_insn(1, 3, 7, 10, 3) > > +#define SYS_DC_CGDVAC sys_insn(1, 3, 7, 10, 5) > > + > > +#define SYS_DC_CVAU sys_insn(1, 3, 7, 11, 1) > > + > > +#define SYS_DC_CVAP sys_insn(1, 3, 7, 12, 1) > > +#define SYS_DC_CGVAP sys_insn(1, 3, 7, 12, 3) > > +#define SYS_DC_CGDVAP sys_insn(1, 3, 7, 12, 5) > > + > > +#define SYS_DC_CVADP sys_insn(1, 3, 7, 13, 1) > > +#define SYS_DC_CGVADP sys_insn(1, 3, 7, 13, 3) > > +#define SYS_DC_CGDVADP sys_insn(1, 3, 7, 13, 5) > > + > > +#define SYS_DC_CIVAC sys_insn(1, 3, 7, 14, 1) > > +#define SYS_DC_CIGVAC sys_insn(1, 3, 7, 14, 3) > > +#define SYS_DC_CIGDVAC sys_insn(1, 3, 7, 14, 5) > > + >=20 > How about sorting these new ones with existing ones to make it more reada= ble? > Otherwise, > Reviewed-by: Jing Zhang Do you mean the DC SW ops? I'd rather keep them separated, as their encoding has a different pattern, and they are treated pretty differently. I found that mixing them with the rest of the DC ops made it *more* difficult to figure out what we were dealing with. Thanks, M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4DDFC001B0 for ; Tue, 15 Aug 2023 10:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aCmsL/l/UKwT1nG7Lsx1YoVSQ2d08RR2yarUqG+WOXo=; b=IlYo201QVNIKou NveEm4QhuARYXeX2TCKZZxK+J9f0Ds4AuvRs+SVbMoOhVSCHDC2jnwcz+BX2p7o+K8WLDr6e4J1qt XzoKzeclVT7DfjezLbki+R247VBS4i3wcSvYMZaorb2CvhjohEtyzx5J2Q+N70Ide+DQuaZJi9uro TRkC3ms87IiLeQWtpualEh0BrpUdO7xLNwAxx2AoePVYU/HNqR4OIhsAr5Rb13Wh3X3oICTBjj6p3 RxV4j2EsAHY75sIcj2MhkQ8kILy59Xa0QZljGApu3wxGklz/kxAI4XJNdaKkQc6CfZOMJ9GNyc2BS wJMc1bLdpuAQ6hI87GkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVrSD-001Ism-1w; Tue, 15 Aug 2023 10:39:13 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVrSA-001Irx-1f for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 10:39:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E3DFF65217; Tue, 15 Aug 2023 10:39:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29BAFC433C7; Tue, 15 Aug 2023 10:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692095949; bh=Gf3HzodU8tLo1mIQprRqSUpWxSeTthPjIQL+JBRkSzg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hPCNwAeaVLW55YAcAFZ6+axIhPjbwlZxgobxFTMyN6do7wyATvRVdDZuoxfTbdcij U/5GDxxMdWjCFa6T+IBkaT0zyqGkjMFHoYdx/cPzey6gDfwz0v1nRRmHLAVIyl5swC plgYvB82cBSsn61TQPFrFQ+QjT1QikhnnF86x07dphFUajWXhrhu6+bUJlLxIxZwD6 BXjwyXV22XtL0KI5gFQ2nStq0vWGZrJbI6gAZErAOZR90+W7ObllkTUYaP+jbFPcoI XnNh+Th+gQj0ut3NMKW33E2nZP+erVTkLbiXZ/5MC+ub9PBr7FEz4STq3zQYuVmONH mcu+hGb5ydF8w== Received: from host213-123-75-60.in-addr.btopenworld.com ([213.123.75.60] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qVrS5-004ycj-VF; Tue, 15 Aug 2023 11:39:07 +0100 Date: Tue, 15 Aug 2023 11:39:18 +0100 Message-ID: <87h6p0pp2h.wl-maz@kernel.org> From: Marc Zyngier To: Jing Zhang Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Eric Auger , Mark Brown , Mark Rutland , Will Deacon , Alexandru Elisei , Andre Przywara , Chase Conklin , Ganapatrao Kulkarni , Darren Hart , Miguel Luis , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH v3 01/27] arm64: Add missing VA CMO encodings In-Reply-To: References: <20230808114711.2013842-1-maz@kernel.org> <20230808114711.2013842-2-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 213.123.75.60 X-SA-Exim-Rcpt-To: jingzhangos@google.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, eric.auger@redhat.com, broonie@kernel.org, mark.rutland@arm.com, will@kernel.org, alexandru.elisei@arm.com, andre.przywara@arm.com, chase.conklin@arm.com, gankulkarni@os.amperecomputing.com, darren@os.amperecomputing.com, miguel.luis@oracle.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_033910_646047_A2E59D5C X-CRM114-Status: GOOD ( 21.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAxMCBBdWcgMjAyMyAwNDoxNDo1MSArMDEwMCwKSmluZyBaaGFuZyA8amluZ3poYW5n b3NAZ29vZ2xlLmNvbT4gd3JvdGU6Cj4gCj4gSGkgTWFyYywKPiAKPiBPbiBUdWUsIEF1ZyA4LCAy MDIzIGF0IDQ6NDfigK9BTSBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPiB3cm90ZToKPiA+ Cj4gPiBBZGQgdGhlIG1pc3NpbmcgVkEtYmFzZWQgQ01PcyBlbmNvZGluZ3MuCj4gPgo+ID4gUmV2 aWV3ZWQtYnk6IEVyaWMgQXVnZXIgPGVyaWMuYXVnZXJAcmVkaGF0LmNvbT4KPiA+IFNpZ25lZC1v ZmYtYnk6IE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+Cj4gPiBSZXZpZXdlZC1ieTogTWln dWVsIEx1aXMgPG1pZ3VlbC5sdWlzQG9yYWNsZS5jb20+Cj4gPiBBY2tlZC1ieTogQ2F0YWxpbiBN YXJpbmFzIDxjYXRhbGluLm1hcmluYXNAYXJtLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBaZW5naHVp IFl1IDx5dXplbmdodWlAaHVhd2VpLmNvbT4KPiA+IC0tLQo+ID4gIGFyY2gvYXJtNjQvaW5jbHVk ZS9hc20vc3lzcmVnLmggfCAyNiArKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIDEgZmls ZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJt NjQvaW5jbHVkZS9hc20vc3lzcmVnLmggYi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL3N5c3JlZy5o Cj4gPiBpbmRleCBiNDgxOTM1ZTkzMTQuLjg1NDQ3ZTY4OTUxYSAxMDA2NDQKPiA+IC0tLSBhL2Fy Y2gvYXJtNjQvaW5jbHVkZS9hc20vc3lzcmVnLmgKPiA+ICsrKyBiL2FyY2gvYXJtNjQvaW5jbHVk ZS9hc20vc3lzcmVnLmgKPiA+IEBAIC0xMjQsNiArMTI0LDMyIEBACj4gPiAgI2RlZmluZSBTWVNf RENfQ0lHU1cgICAgICAgICAgICAgICAgICAgc3lzX2luc24oMSwgMCwgNywgMTQsIDQpCj4gPiAg I2RlZmluZSBTWVNfRENfQ0lHRFNXICAgICAgICAgICAgICAgICAgc3lzX2luc24oMSwgMCwgNywg MTQsIDYpCj4gPgo+ID4gKyNkZWZpbmUgU1lTX0lDX0lBTExVSVMgICAgICAgICAgICAgICAgIHN5 c19pbnNuKDEsIDAsIDcsIDEsIDApCj4gPiArI2RlZmluZSBTWVNfSUNfSUFMTFUgICAgICAgICAg ICAgICAgICAgc3lzX2luc24oMSwgMCwgNywgNSwgMCkKPiA+ICsjZGVmaW5lIFNZU19JQ19JVkFV ICAgICAgICAgICAgICAgICAgICBzeXNfaW5zbigxLCAzLCA3LCA1LCAxKQo+ID4gKwo+ID4gKyNk ZWZpbmUgU1lTX0RDX0lWQUMgICAgICAgICAgICAgICAgICAgIHN5c19pbnNuKDEsIDAsIDcsIDYs IDEpCj4gPiArI2RlZmluZSBTWVNfRENfSUdWQUMgICAgICAgICAgICAgICAgICAgc3lzX2luc24o MSwgMCwgNywgNiwgMykKPiA+ICsjZGVmaW5lIFNZU19EQ19JR0RWQUMgICAgICAgICAgICAgICAg ICBzeXNfaW5zbigxLCAwLCA3LCA2LCA1KQo+ID4gKwo+ID4gKyNkZWZpbmUgU1lTX0RDX0NWQUMg ICAgICAgICAgICAgICAgICAgIHN5c19pbnNuKDEsIDMsIDcsIDEwLCAxKQo+ID4gKyNkZWZpbmUg U1lTX0RDX0NHVkFDICAgICAgICAgICAgICAgICAgIHN5c19pbnNuKDEsIDMsIDcsIDEwLCAzKQo+ ID4gKyNkZWZpbmUgU1lTX0RDX0NHRFZBQyAgICAgICAgICAgICAgICAgIHN5c19pbnNuKDEsIDMs IDcsIDEwLCA1KQo+ID4gKwo+ID4gKyNkZWZpbmUgU1lTX0RDX0NWQVUgICAgICAgICAgICAgICAg ICAgIHN5c19pbnNuKDEsIDMsIDcsIDExLCAxKQo+ID4gKwo+ID4gKyNkZWZpbmUgU1lTX0RDX0NW QVAgICAgICAgICAgICAgICAgICAgIHN5c19pbnNuKDEsIDMsIDcsIDEyLCAxKQo+ID4gKyNkZWZp bmUgU1lTX0RDX0NHVkFQICAgICAgICAgICAgICAgICAgIHN5c19pbnNuKDEsIDMsIDcsIDEyLCAz KQo+ID4gKyNkZWZpbmUgU1lTX0RDX0NHRFZBUCAgICAgICAgICAgICAgICAgIHN5c19pbnNuKDEs IDMsIDcsIDEyLCA1KQo+ID4gKwo+ID4gKyNkZWZpbmUgU1lTX0RDX0NWQURQICAgICAgICAgICAg ICAgICAgIHN5c19pbnNuKDEsIDMsIDcsIDEzLCAxKQo+ID4gKyNkZWZpbmUgU1lTX0RDX0NHVkFE UCAgICAgICAgICAgICAgICAgIHN5c19pbnNuKDEsIDMsIDcsIDEzLCAzKQo+ID4gKyNkZWZpbmUg U1lTX0RDX0NHRFZBRFAgICAgICAgICAgICAgICAgIHN5c19pbnNuKDEsIDMsIDcsIDEzLCA1KQo+ ID4gKwo+ID4gKyNkZWZpbmUgU1lTX0RDX0NJVkFDICAgICAgICAgICAgICAgICAgIHN5c19pbnNu KDEsIDMsIDcsIDE0LCAxKQo+ID4gKyNkZWZpbmUgU1lTX0RDX0NJR1ZBQyAgICAgICAgICAgICAg ICAgIHN5c19pbnNuKDEsIDMsIDcsIDE0LCAzKQo+ID4gKyNkZWZpbmUgU1lTX0RDX0NJR0RWQUMg ICAgICAgICAgICAgICAgIHN5c19pbnNuKDEsIDMsIDcsIDE0LCA1KQo+ID4gKwo+IAo+IEhvdyBh Ym91dCBzb3J0aW5nIHRoZXNlIG5ldyBvbmVzIHdpdGggZXhpc3Rpbmcgb25lcyB0byBtYWtlIGl0 IG1vcmUgcmVhZGFibGU/Cj4gT3RoZXJ3aXNlLAo+IFJldmlld2VkLWJ5OiBKaW5nIFpoYW5nIDxq aW5nemhhbmdvc0Bnb29nbGUuY29tPgoKRG8geW91IG1lYW4gdGhlIERDIFNXIG9wcz8gSSdkIHJh dGhlciBrZWVwIHRoZW0gc2VwYXJhdGVkLCBhcyB0aGVpcgplbmNvZGluZyBoYXMgYSBkaWZmZXJl bnQgcGF0dGVybiwgYW5kIHRoZXkgYXJlIHRyZWF0ZWQgcHJldHR5CmRpZmZlcmVudGx5LiBJIGZv dW5kIHRoYXQgbWl4aW5nIHRoZW0gd2l0aCB0aGUgcmVzdCBvZiB0aGUgREMgb3BzIG1hZGUKaXQg Km1vcmUqIGRpZmZpY3VsdCB0byBmaWd1cmUgb3V0IHdoYXQgd2Ugd2VyZSBkZWFsaW5nIHdpdGgu CgpUaGFua3MsCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9n cmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==