From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A220ED52D for ; Mon, 7 Aug 2023 12:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691412232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pgN6ITNOX4XAghEqnE7rc109x2dPHO2XXLtjfGMGEBw=; b=LSz023+IQo4sXMIH2KlDyORQsIuvRahWymjImd8r3DhPfmUb8Tih+r8bV4f1hh2wuLze3t gWeNgMx2zr/3Nz/Ep4TGFcGpwMPnBKUqbPSFvtiE8iZsDMqmY7GYsa3kT0cZGjRvqJrMoB dHgcSVw7sMoXZesJMaH+qLycQS5j/KU= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-558-VkhQ3GWqNk66vZeVUGT2Qw-1; Mon, 07 Aug 2023 08:43:49 -0400 X-MC-Unique: VkhQ3GWqNk66vZeVUGT2Qw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BD5F6381AE49; Mon, 7 Aug 2023 12:43:43 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6342E40C2076; Mon, 7 Aug 2023 12:43:40 +0000 (UTC) From: Florian Weimer To: Jakub Jelinek Cc: Marco Elver , Andrew Morton , Kees Cook , Guenter Roeck , Peter Zijlstra , Mark Rutland , Steven Rostedt , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Nathan Chancellor , Nick Desaulniers , Tom Rix , Miguel Ojeda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Dmitry Vyukov , Alexander Potapenko , kasan-dev@googlegroups.com, linux-toolchains@vger.kernel.org Subject: Re: [PATCH v2 1/3] compiler_types: Introduce the Clang __preserve_most function attribute References: <20230804090621.400-1-elver@google.com> <87il9rgjvw.fsf@oldenburg.str.redhat.com> Date: Mon, 07 Aug 2023 14:43:39 +0200 In-Reply-To: (Jakub Jelinek's message of "Mon, 7 Aug 2023 14:38:05 +0200") Message-ID: <87h6pbf2f8.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 * Jakub Jelinek: > On Mon, Aug 07, 2023 at 02:24:26PM +0200, Marco Elver wrote: >> > | If the arguments are passed in callee-saved registers, then they will >> > | be preserved by the callee across the call. This doesn=E2=80=99t app= ly for >> > | values returned in callee-saved registers. >> > | >> > | =C2=B7 On X86-64 the callee preserves all general purpose register= s, except >> > | for R11. R11 can be used as a scratch register. Floating-point >> > | registers (XMMs/YMMs) are not preserved and need to be saved by = the >> > | caller. >> > | >> > | =C2=B7 On AArch64 the callee preserve all general purpose register= s, except >> > | X0-X8 and X16-X18. >> > >> > Ideally, this would be documented in the respective psABI supplement. >> > I filled in some gaps and filed: >> > >> > Document the ABI for __preserve_most__ function calls >> > >>=20 >> Good idea. I had already created >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110899, and we need >> better spec to proceed for GCC anyway. > > "Registers used for passing arguments > are preserved by the called function, but registers used for > returning results are not." > > You mean just GPRs or also vector SSE or MMX registers? I think this is pretty clear for x86-64: | Floating-point registers (XMMs/YMMs) are not preserved and need to be | saved by the caller. The issue is more with future GPR extensions like APX. Thanks, Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0A6EC04A6A for ; Mon, 7 Aug 2023 12:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qXI7tEMFmgzq/LRXbGHP5z5GxlTy5hJThJyOFaSk5Z0=; b=fmzuATG7YM1L1t PgiYGk3xBDZqnR9oSC9ZD9i5g27CNCRsVyHdoTPHGqFFTLspNKrutij8OiBpMty1YjGN+NcDRmNGk zWvGY1irEkGb2m7wT9GOYGyEujcgrc3nAKglNJGHtsT9hs5kvauX7o8RIn1NQQGIM2ObUJfTqnc8o H4GrCixFfYeqJdyOeDq3HLNMH9jLzCm7wrQsxwzcsnFQqJzKVMpN37G5ar3NS2sjhv6R/n9OV5P5X f549zm30LW0T4aeUJGDmxFVQ1SDgbHXPvyiVqYiNR6xcbAzFmURSN9MQuW3qwzfJAFd6w2akFz0Py gkBGd4YI1n9IiMljg8Aw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSzaU-00HFfA-2a; Mon, 07 Aug 2023 12:43:54 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSzaR-00HFde-2H for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 12:43:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691412230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pgN6ITNOX4XAghEqnE7rc109x2dPHO2XXLtjfGMGEBw=; b=fNiTZ+Ju0r2fCC0CxqgYpD6EbR6b/NAEEkxcljT+CfVuhf7lskS2EBDY9cT95MiXEw3ze8 0UDvvoi1KnBhKad9lMzEdDYlLXqscZ9mFqBd78OPTvVNqfNE149U8u66Jd+TztuChT9DSX jWxk4z1Cd64Tbh8+vQYDLFMQelzm9zc= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-558-VkhQ3GWqNk66vZeVUGT2Qw-1; Mon, 07 Aug 2023 08:43:49 -0400 X-MC-Unique: VkhQ3GWqNk66vZeVUGT2Qw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BD5F6381AE49; Mon, 7 Aug 2023 12:43:43 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6342E40C2076; Mon, 7 Aug 2023 12:43:40 +0000 (UTC) From: Florian Weimer To: Jakub Jelinek Cc: Marco Elver , Andrew Morton , Kees Cook , Guenter Roeck , Peter Zijlstra , Mark Rutland , Steven Rostedt , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Nathan Chancellor , Nick Desaulniers , Tom Rix , Miguel Ojeda , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Dmitry Vyukov , Alexander Potapenko , kasan-dev@googlegroups.com, linux-toolchains@vger.kernel.org Subject: Re: [PATCH v2 1/3] compiler_types: Introduce the Clang __preserve_most function attribute References: <20230804090621.400-1-elver@google.com> <87il9rgjvw.fsf@oldenburg.str.redhat.com> Date: Mon, 07 Aug 2023 14:43:39 +0200 In-Reply-To: (Jakub Jelinek's message of "Mon, 7 Aug 2023 14:38:05 +0200") Message-ID: <87h6pbf2f8.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_054351_813943_F21D3979 X-CRM114-Status: GOOD ( 22.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBKYWt1YiBKZWxpbmVrOgoKPiBPbiBNb24sIEF1ZyAwNywgMjAyMyBhdCAwMjoyNDoyNlBNICsw MjAwLCBNYXJjbyBFbHZlciB3cm90ZToKPj4gPiB8IElmIHRoZSBhcmd1bWVudHMgYXJlIHBhc3Nl ZCBpbiBjYWxsZWUtc2F2ZWQgcmVnaXN0ZXJzLCB0aGVuIHRoZXkgd2lsbAo+PiA+IHwgYmUgcHJl c2VydmVkIGJ5IHRoZSBjYWxsZWUgYWNyb3NzIHRoZSBjYWxsLiBUaGlzIGRvZXNu4oCZdCBhcHBs eSBmb3IKPj4gPiB8IHZhbHVlcyByZXR1cm5lZCBpbiBjYWxsZWUtc2F2ZWQgcmVnaXN0ZXJzLgo+ PiA+IHwKPj4gPiB8ICDCtyAgT24gWDg2LTY0IHRoZSBjYWxsZWUgcHJlc2VydmVzIGFsbCBnZW5l cmFsIHB1cnBvc2UgcmVnaXN0ZXJzLCBleGNlcHQKPj4gPiB8ICAgICBmb3IgUjExLiBSMTEgY2Fu IGJlIHVzZWQgYXMgYSBzY3JhdGNoIHJlZ2lzdGVyLiBGbG9hdGluZy1wb2ludAo+PiA+IHwgICAg IHJlZ2lzdGVycyAoWE1Ncy9ZTU1zKSBhcmUgbm90IHByZXNlcnZlZCBhbmQgbmVlZCB0byBiZSBz YXZlZCBieSB0aGUKPj4gPiB8ICAgICBjYWxsZXIuCj4+ID4gfAo+PiA+IHwgIMK3ICBPbiBBQXJj aDY0IHRoZSBjYWxsZWUgcHJlc2VydmUgYWxsIGdlbmVyYWwgcHVycG9zZSByZWdpc3RlcnMsIGV4 Y2VwdAo+PiA+IHwgICAgIFgwLVg4IGFuZCBYMTYtWDE4Lgo+PiA+Cj4+ID4gSWRlYWxseSwgdGhp cyB3b3VsZCBiZSBkb2N1bWVudGVkIGluIHRoZSByZXNwZWN0aXZlIHBzQUJJIHN1cHBsZW1lbnQu Cj4+ID4gSSBmaWxsZWQgaW4gc29tZSBnYXBzIGFuZCBmaWxlZDoKPj4gPgo+PiA+ICAgRG9jdW1l bnQgdGhlIEFCSSBmb3IgX19wcmVzZXJ2ZV9tb3N0X18gZnVuY3Rpb24gY2FsbHMKPj4gPiAgIDxo dHRwczovL2dpdGxhYi5jb20veDg2LXBzQUJJcy94ODYtNjQtQUJJLy0vbWVyZ2VfcmVxdWVzdHMv NDU+Cj4+IAo+PiBHb29kIGlkZWEuIEkgaGFkIGFscmVhZHkgY3JlYXRlZAo+PiBodHRwczovL2dj Yy5nbnUub3JnL2J1Z3ppbGxhL3Nob3dfYnVnLmNnaT9pZD0xMTA4OTksIGFuZCB3ZSBuZWVkCj4+ IGJldHRlciBzcGVjIHRvIHByb2NlZWQgZm9yIEdDQyBhbnl3YXkuCj4KPiAiUmVnaXN0ZXJzIHVz ZWQgZm9yIHBhc3NpbmcgYXJndW1lbnRzCj4gYXJlIHByZXNlcnZlZCBieSB0aGUgY2FsbGVkIGZ1 bmN0aW9uLCBidXQgcmVnaXN0ZXJzIHVzZWQgZm9yCj4gcmV0dXJuaW5nIHJlc3VsdHMgYXJlIG5v dC4iCj4KPiBZb3UgbWVhbiBqdXN0IEdQUnMgb3IgYWxzbyB2ZWN0b3IgU1NFIG9yIE1NWCByZWdp c3RlcnM/CgpJIHRoaW5rIHRoaXMgaXMgcHJldHR5IGNsZWFyIGZvciB4ODYtNjQ6Cgp8IEZsb2F0 aW5nLXBvaW50IHJlZ2lzdGVycyAoWE1Ncy9ZTU1zKSBhcmUgbm90IHByZXNlcnZlZCBhbmQgbmVl ZCB0byBiZQp8IHNhdmVkIGJ5IHRoZSBjYWxsZXIuCgpUaGUgaXNzdWUgaXMgbW9yZSB3aXRoIGZ1 dHVyZSBHUFIgZXh0ZW5zaW9ucyBsaWtlIEFQWC4KClRoYW5rcywKRmxvcmlhbgoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK