From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABA5C001B0 for ; Fri, 30 Jun 2023 11:12:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232853AbjF3LMM (ORCPT ); Fri, 30 Jun 2023 07:12:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232848AbjF3LL7 (ORCPT ); Fri, 30 Jun 2023 07:11:59 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEF4735B6; Fri, 30 Jun 2023 04:11:48 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1688123506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LBi2xn+NWrUQzLbxhPhUtfNKTaMAus8XdZkjy6jHSNM=; b=418LKbfzErO8aWbRiCy6RicHEfWmrfLoIcdhuAdqKEQ/ZbLyV5fOr9TL2jgmxbiB1UJ3bl L7RSNcul7PGGKtMoVG58xOTYMswwl0fvl2x6Gy3oeK78nmBEYbydnR6FVElSSy3QDkkQS4 aNdClghzIVSlb1kIYZa+lxNsG6dKqXTENfkuKKK8H3fwdANqYJnMII3qHGkdR7RslbGNzH rMZSPPYA/DaN+m+jbNSRocp1b1dwjRh2NBrN92RDYtVGXNSXIAHcc+RtRHjhZQcR/LI027 /C9gb1mFySWZHISgYn13LNhN7Izd0dCqTTysj0/z5qIQHqLoTPKk/6VDB9l9vg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1688123506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LBi2xn+NWrUQzLbxhPhUtfNKTaMAus8XdZkjy6jHSNM=; b=jVPJlwFMcCzb0wYuBYE9xW6cZEwUMtJR24us2ZwmMLiYkh/Ya8FPIpIwdTH1G8h/qMJoP9 yy6W7RPJnQ28ZkBA== To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Yangtao Li Cc: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, thara.gopinath@gmail.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, srinivas.pandruvada@linux.intel.com, DLG-Adam.Ward.opensource@dm.renesas.com, shangxiaojing@huawei.com, bchihi@baylibre.com, wenst@chromium.org, hayashi.kunihiko@socionext.com, niklas.soderlund+renesas@ragnatech.se, chi.minghao@zte.com.cn, johan+linaro@kernel.org, jernej.skrabec@gmail.com, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/15] genirq/devres: Add error information printing for devm_request_threaded_irq() In-Reply-To: <20230627110025.vgtplc6nluiiuvoh@pengutronix.de> References: <20230627101215.58798-1-frank.li@vivo.com> <20230627110025.vgtplc6nluiiuvoh@pengutronix.de> Date: Fri, 30 Jun 2023 13:11:46 +0200 Message-ID: <87h6qpyzkd.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jun 27 2023 at 13:00, Uwe Kleine-K=C3=B6nig wrote: > On Tue, Jun 27, 2023 at 06:12:01PM +0800, Yangtao Li wrote: > > While I assume changing to dev_err_probe is a result of my concern that > no error should be printed when rc=3D-EPROBEDEFER, my other concern that > adding an error message to a generic allocation function is a bad idea > still stands. I agree in general, but if you actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. Yangtao: The way how this is attempted is not useful at all. 1) The changelog is word salad and provides 0 rationale Also such series require a cover letter... 2) The dev_err() which is added is not informative at all and cannot replace actually useful error messages. It's not that hard to make it useful. 2) Adding the printks unconditionally first will emit two messages with different content. This is not how such changes are done. The proper approach is to create a wrapper function which emits the error message: wrapper(....., const char *info) { ret =3D devm_request_threaded_irq(....); if (ret < 0) { dev_err(dev, "Failed to request %sinterrupt %u %s %s: %d\n, thread_fn ? "threaded " : "", irq, devname, info ? : "", ret); } return ret; } Then convert the callsites over one by one with proper changelogs and justification. See? Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42757EB64D7 for ; Fri, 30 Jun 2023 11:12:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eGxV7zwTHYJv69kuIbjm1MyVxmmn1PM2XWYLMkBukFY=; b=3OlObood5wSVXe m8tsIkHhOuuTT8czErE8bQ84ttcADCRhWBbSO1T3eGRyW1FRhYmWty+1lBWthwEdszL0NRbNlxmm+ tgaAY+3GlFd2sYvtClygE/OqTqYR/2u8QMQ3iWySCORp+Sp1ZffjO8JTirMmU83afP4qtt5Z4zHwv 7COPwjm9H5gzSnddNTXPaRTjevAAobFEsoUeSOTJJnITvUzL0VonMSauwpEEM8ypuo1Ob8Y3hYqsF w1cNhkrHEtRaxXL6xw4qfazBUN7fAZYKk2CJJQyG0XbX4VXMF3+O5q2ALrasMK30ynMyet3BaaixC 2Yh+P2bNNg1UFR2W9Vgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qFC2a-003ZLa-1a; Fri, 30 Jun 2023 11:11:52 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qFC2X-003ZKg-0M; Fri, 30 Jun 2023 11:11:50 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1688123506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LBi2xn+NWrUQzLbxhPhUtfNKTaMAus8XdZkjy6jHSNM=; b=418LKbfzErO8aWbRiCy6RicHEfWmrfLoIcdhuAdqKEQ/ZbLyV5fOr9TL2jgmxbiB1UJ3bl L7RSNcul7PGGKtMoVG58xOTYMswwl0fvl2x6Gy3oeK78nmBEYbydnR6FVElSSy3QDkkQS4 aNdClghzIVSlb1kIYZa+lxNsG6dKqXTENfkuKKK8H3fwdANqYJnMII3qHGkdR7RslbGNzH rMZSPPYA/DaN+m+jbNSRocp1b1dwjRh2NBrN92RDYtVGXNSXIAHcc+RtRHjhZQcR/LI027 /C9gb1mFySWZHISgYn13LNhN7Izd0dCqTTysj0/z5qIQHqLoTPKk/6VDB9l9vg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1688123506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LBi2xn+NWrUQzLbxhPhUtfNKTaMAus8XdZkjy6jHSNM=; b=jVPJlwFMcCzb0wYuBYE9xW6cZEwUMtJR24us2ZwmMLiYkh/Ya8FPIpIwdTH1G8h/qMJoP9 yy6W7RPJnQ28ZkBA== To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Yangtao Li Cc: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, thara.gopinath@gmail.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, srinivas.pandruvada@linux.intel.com, DLG-Adam.Ward.opensource@dm.renesas.com, shangxiaojing@huawei.com, bchihi@baylibre.com, wenst@chromium.org, hayashi.kunihiko@socionext.com, niklas.soderlund+renesas@ragnatech.se, chi.minghao@zte.com.cn, johan+linaro@kernel.org, jernej.skrabec@gmail.com, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/15] genirq/devres: Add error information printing for devm_request_threaded_irq() In-Reply-To: <20230627110025.vgtplc6nluiiuvoh@pengutronix.de> References: <20230627101215.58798-1-frank.li@vivo.com> <20230627110025.vgtplc6nluiiuvoh@pengutronix.de> Date: Fri, 30 Jun 2023 13:11:46 +0200 Message-ID: <87h6qpyzkd.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230630_041149_303357_2B300F0A X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMjcgMjAyMyBhdCAxMzowMCwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4g T24gVHVlLCBKdW4gMjcsIDIwMjMgYXQgMDY6MTI6MDFQTSArMDgwMCwgWWFuZ3RhbyBMaSB3cm90 ZToKPgo+IFdoaWxlIEkgYXNzdW1lIGNoYW5naW5nIHRvIGRldl9lcnJfcHJvYmUgaXMgYSByZXN1 bHQgb2YgbXkgY29uY2VybiB0aGF0Cj4gbm8gZXJyb3Igc2hvdWxkIGJlIHByaW50ZWQgd2hlbiBy Yz0tRVBST0JFREVGRVIsIG15IG90aGVyIGNvbmNlcm4gdGhhdAo+IGFkZGluZyBhbiBlcnJvciBt ZXNzYWdlIHRvIGEgZ2VuZXJpYyBhbGxvY2F0aW9uIGZ1bmN0aW9uIGlzIGEgYmFkIGlkZWEKPiBz dGlsbCBzdGFuZHMuCgpJIGFncmVlIGluIGdlbmVyYWwsIGJ1dCBpZiB5b3UgYWN0dWFsbHkgbG9v ayBhdCB0aGUgY2FsbCBzaXRlcyBvZgpkZXZtX3JlcXVlc3RfdGhyZWFkZWRfaXJxKCkgdGhlbiB0 aGUgdmFzdCBtYWpvcml0eSBvZiB0aGVtIHByaW50IG1vcmUgb3IKbGVzcyBsb3VzeSBlcnJvciBt ZXNzYWdlcy4gQSBxdWljayBncmVwL3NlZC9hd2svc29ydC91bmlxIHJldmVhbGVkCgogICAgIDUx OSBtZXNzYWdlcyB0b3RhbCAodGhlcmUgYXJlIHByb2JhYmx5IG1vcmUpCgogICAgIDM1MiB1bmlx dWUgbWVzc2FnZXMKCiAgICAgMzIzIHVuaXF1ZSBtZXNzYWdlcyBhZnRlciBsb3dlciBjYXNpbmcK CiAgICAgICAgIFRob3NlIDMyMyBhcmUgbW9zdGx5IGp1c3QgdmFyaWFudHMgb2YgdGhlIHNhbWUg cGF0dGVybnMgd2l0aCBzbGlnaHQKICAgICAgICAgbW9kaWZpY2F0aW9ucyBpbiBmb3JtYXR0aW5n IGFuZCBpbmZvcm1hdGlvbiBwcm92aWRlZC4KCiAgICAgMTg2IG9mIHRoZXNlIG1lc3NhZ2VzIGRv IG5vdCBkZWxpdmVyIGFueSB1c2VmdWwgaW5mb3JtYXRpb24sCiAgICAgICAgIGUuZy4gIm5vIGly cSIsICIKCiAgICAgVGhlIG1vc3QgdXNlZnVsIG9uZSBvZiBhbGwgaXM6ICJjb3VsZCByZXF1ZXN0 IHdha2V1cCBpcnE6ICVkIgoKU28gdGhlcmUgaXMgY2VydGFpbmx5IGFuIGFyZ3VtZW50IHRvIGJl IG1hZGUgdGhhdCB0aGlzIHBhcnRpY3VsYXIKZnVuY3Rpb24gc2hvdWxkIHByaW50IGEgd2VsbCBm b3JtYXR0ZWQgYW5kIGluZm9ybWF0aXZlIGVycm9yIG1lc3NhZ2UuCgpJdCdzIG5vdCBhIGdlbmVy YWwgYWxsb2NhdG9yIGxpa2Uga21hbGxvYygpLiBJdCdzIHNwZWNpYWxpemVkIGFuZCBpbiB0aGUK dmFzdCBtYWpvcml0eSBvZiBjYXNlcyBmYWlsaW5nIHRvIHJlcXVlc3QgdGhlIGludGVycnVwdCBj YXVzZXMgdGhlCmRldmljZSBwcm9iZSB0byBmYWlsLiBTbyBoYXZpbmcgcHJvcGVyIGFuZCBjb25z aXN0ZW50IGluZm9ybWF0aW9uIHdoeQp0aGUgZGV2aWNlIGNhbm5vdCBiZSB1c2VkIF9pc18gdXNl ZnVsLgoKWWFuZ3RhbzogVGhlIHdheSBob3cgdGhpcyBpcyBhdHRlbXB0ZWQgaXMgbm90IHVzZWZ1 bCBhdCBhbGwuCgogICAgMSkgVGhlIGNoYW5nZWxvZyBpcyB3b3JkIHNhbGFkIGFuZCBwcm92aWRl cyAwIHJhdGlvbmFsZQoKICAgICAgIEFsc28gc3VjaCBzZXJpZXMgcmVxdWlyZSBhIGNvdmVyIGxl dHRlci4uLgoKICAgIDIpIFRoZSBkZXZfZXJyKCkgd2hpY2ggaXMgYWRkZWQgaXMgbm90IGluZm9y bWF0aXZlIGF0IGFsbCBhbmQgY2Fubm90CiAgICAgICByZXBsYWNlIGFjdHVhbGx5IHVzZWZ1bCBl cnJvciBtZXNzYWdlcy4gSXQncyBub3QgdGhhdCBoYXJkIHRvCiAgICAgICBtYWtlIGl0IHVzZWZ1 bC4KCiAgICAyKSBBZGRpbmcgdGhlIHByaW50a3MgdW5jb25kaXRpb25hbGx5IGZpcnN0IHdpbGwg ZW1pdCB0d28gbWVzc2FnZXMKICAgICAgIHdpdGggZGlmZmVyZW50IGNvbnRlbnQuCgogICAgICAg VGhpcyBpcyBub3QgaG93IHN1Y2ggY2hhbmdlcyBhcmUgZG9uZS4KCiAgICAgICBUaGUgcHJvcGVy IGFwcHJvYWNoIGlzIHRvIGNyZWF0ZSBhIHdyYXBwZXIgZnVuY3Rpb24gd2hpY2ggZW1pdHMKICAg ICAgIHRoZSBlcnJvciBtZXNzYWdlOgoKICAgICAgIHdyYXBwZXIoLi4uLi4sIGNvbnN0IGNoYXIg KmluZm8pCiAgICAgICB7CiAgICAgICAgICAgIHJldCA9IGRldm1fcmVxdWVzdF90aHJlYWRlZF9p cnEoLi4uLik7CiAgICAgICAgICAgIGlmIChyZXQgPCAwKSB7CiAgICAgICAgICAgICAgIGRldl9l cnIoZGV2LCAiRmFpbGVkIHRvIHJlcXVlc3QgJXNpbnRlcnJ1cHQgJXUgJXMgJXM6ICVkXG4sCiAg ICAgICAgICAgICAgICAgICAgICAgdGhyZWFkX2ZuID8gInRocmVhZGVkICIgOiAiIiwKICAgICAg ICAgICAgICAgICAgICAgICBpcnEsIGRldm5hbWUsIGluZm8gPyA6ICIiLCByZXQpOwogICAgICAg ICAgICB9CiAgICAgICAgICAgIHJldHVybiByZXQ7CiAgICAgICB9CgogICAgICAgVGhlbiBjb252 ZXJ0IHRoZSBjYWxsc2l0ZXMgb3ZlciBvbmUgYnkgb25lIHdpdGggcHJvcGVyCiAgICAgICBjaGFu Z2Vsb2dzIGFuZCBqdXN0aWZpY2F0aW9uLgoKICAgICAgIFNlZT8KClRoYW5rcywKCiAgICAgICAg dGdseAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGlu dXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2Nr Y2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 976DCEB64D7 for ; Fri, 30 Jun 2023 11:12:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O260n8Py0eLwsYXiOb7va0A3ppihDAqZ0L5ZQL1NsXQ=; b=iu4bTjH73VM1nR Xkxc+E4y5BIIRVlIRmSi0AdhMCe/CSu96JSRGcCtLzHiCTFEJGpMHV6N7U01tjiMg9T0EtFObykBo 7KjmueIo4ul7uKfTg0o+H4mdFqx/JjGWdsE+YanMvFAiV4gan0YtX9M/2mhdoepqm7sAd7YXQMQTd FDgTTyk0lSCN1KZhAvSPFhZvhGlCJ8/MqZ6vKJPT3iE/EKs0dTa4Etm0gDwvVkydI3Jy/gNnvCFDI kHJcSGc40XwDWlnQeGfRfRvV2W+NN2bcA6BqiQgnLwMOttavNgSCFnFX9+1g9PQIrqtUpnuguiTJe FFdtKVW4/sNop3mWxV0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qFC2Z-003ZLG-1x; Fri, 30 Jun 2023 11:11:51 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qFC2X-003ZKg-0M; Fri, 30 Jun 2023 11:11:50 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1688123506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LBi2xn+NWrUQzLbxhPhUtfNKTaMAus8XdZkjy6jHSNM=; b=418LKbfzErO8aWbRiCy6RicHEfWmrfLoIcdhuAdqKEQ/ZbLyV5fOr9TL2jgmxbiB1UJ3bl L7RSNcul7PGGKtMoVG58xOTYMswwl0fvl2x6Gy3oeK78nmBEYbydnR6FVElSSy3QDkkQS4 aNdClghzIVSlb1kIYZa+lxNsG6dKqXTENfkuKKK8H3fwdANqYJnMII3qHGkdR7RslbGNzH rMZSPPYA/DaN+m+jbNSRocp1b1dwjRh2NBrN92RDYtVGXNSXIAHcc+RtRHjhZQcR/LI027 /C9gb1mFySWZHISgYn13LNhN7Izd0dCqTTysj0/z5qIQHqLoTPKk/6VDB9l9vg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1688123506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LBi2xn+NWrUQzLbxhPhUtfNKTaMAus8XdZkjy6jHSNM=; b=jVPJlwFMcCzb0wYuBYE9xW6cZEwUMtJR24us2ZwmMLiYkh/Ya8FPIpIwdTH1G8h/qMJoP9 yy6W7RPJnQ28ZkBA== To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Yangtao Li Cc: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, thara.gopinath@gmail.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, thierry.reding@gmail.com, jonathanh@nvidia.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, srinivas.pandruvada@linux.intel.com, DLG-Adam.Ward.opensource@dm.renesas.com, shangxiaojing@huawei.com, bchihi@baylibre.com, wenst@chromium.org, hayashi.kunihiko@socionext.com, niklas.soderlund+renesas@ragnatech.se, chi.minghao@zte.com.cn, johan+linaro@kernel.org, jernej.skrabec@gmail.com, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/15] genirq/devres: Add error information printing for devm_request_threaded_irq() In-Reply-To: <20230627110025.vgtplc6nluiiuvoh@pengutronix.de> References: <20230627101215.58798-1-frank.li@vivo.com> <20230627110025.vgtplc6nluiiuvoh@pengutronix.de> Date: Fri, 30 Jun 2023 13:11:46 +0200 Message-ID: <87h6qpyzkd.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230630_041149_303357_2B300F0A X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMjcgMjAyMyBhdCAxMzowMCwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4g T24gVHVlLCBKdW4gMjcsIDIwMjMgYXQgMDY6MTI6MDFQTSArMDgwMCwgWWFuZ3RhbyBMaSB3cm90 ZToKPgo+IFdoaWxlIEkgYXNzdW1lIGNoYW5naW5nIHRvIGRldl9lcnJfcHJvYmUgaXMgYSByZXN1 bHQgb2YgbXkgY29uY2VybiB0aGF0Cj4gbm8gZXJyb3Igc2hvdWxkIGJlIHByaW50ZWQgd2hlbiBy Yz0tRVBST0JFREVGRVIsIG15IG90aGVyIGNvbmNlcm4gdGhhdAo+IGFkZGluZyBhbiBlcnJvciBt ZXNzYWdlIHRvIGEgZ2VuZXJpYyBhbGxvY2F0aW9uIGZ1bmN0aW9uIGlzIGEgYmFkIGlkZWEKPiBz dGlsbCBzdGFuZHMuCgpJIGFncmVlIGluIGdlbmVyYWwsIGJ1dCBpZiB5b3UgYWN0dWFsbHkgbG9v ayBhdCB0aGUgY2FsbCBzaXRlcyBvZgpkZXZtX3JlcXVlc3RfdGhyZWFkZWRfaXJxKCkgdGhlbiB0 aGUgdmFzdCBtYWpvcml0eSBvZiB0aGVtIHByaW50IG1vcmUgb3IKbGVzcyBsb3VzeSBlcnJvciBt ZXNzYWdlcy4gQSBxdWljayBncmVwL3NlZC9hd2svc29ydC91bmlxIHJldmVhbGVkCgogICAgIDUx OSBtZXNzYWdlcyB0b3RhbCAodGhlcmUgYXJlIHByb2JhYmx5IG1vcmUpCgogICAgIDM1MiB1bmlx dWUgbWVzc2FnZXMKCiAgICAgMzIzIHVuaXF1ZSBtZXNzYWdlcyBhZnRlciBsb3dlciBjYXNpbmcK CiAgICAgICAgIFRob3NlIDMyMyBhcmUgbW9zdGx5IGp1c3QgdmFyaWFudHMgb2YgdGhlIHNhbWUg cGF0dGVybnMgd2l0aCBzbGlnaHQKICAgICAgICAgbW9kaWZpY2F0aW9ucyBpbiBmb3JtYXR0aW5n IGFuZCBpbmZvcm1hdGlvbiBwcm92aWRlZC4KCiAgICAgMTg2IG9mIHRoZXNlIG1lc3NhZ2VzIGRv IG5vdCBkZWxpdmVyIGFueSB1c2VmdWwgaW5mb3JtYXRpb24sCiAgICAgICAgIGUuZy4gIm5vIGly cSIsICIKCiAgICAgVGhlIG1vc3QgdXNlZnVsIG9uZSBvZiBhbGwgaXM6ICJjb3VsZCByZXF1ZXN0 IHdha2V1cCBpcnE6ICVkIgoKU28gdGhlcmUgaXMgY2VydGFpbmx5IGFuIGFyZ3VtZW50IHRvIGJl IG1hZGUgdGhhdCB0aGlzIHBhcnRpY3VsYXIKZnVuY3Rpb24gc2hvdWxkIHByaW50IGEgd2VsbCBm b3JtYXR0ZWQgYW5kIGluZm9ybWF0aXZlIGVycm9yIG1lc3NhZ2UuCgpJdCdzIG5vdCBhIGdlbmVy YWwgYWxsb2NhdG9yIGxpa2Uga21hbGxvYygpLiBJdCdzIHNwZWNpYWxpemVkIGFuZCBpbiB0aGUK dmFzdCBtYWpvcml0eSBvZiBjYXNlcyBmYWlsaW5nIHRvIHJlcXVlc3QgdGhlIGludGVycnVwdCBj YXVzZXMgdGhlCmRldmljZSBwcm9iZSB0byBmYWlsLiBTbyBoYXZpbmcgcHJvcGVyIGFuZCBjb25z aXN0ZW50IGluZm9ybWF0aW9uIHdoeQp0aGUgZGV2aWNlIGNhbm5vdCBiZSB1c2VkIF9pc18gdXNl ZnVsLgoKWWFuZ3RhbzogVGhlIHdheSBob3cgdGhpcyBpcyBhdHRlbXB0ZWQgaXMgbm90IHVzZWZ1 bCBhdCBhbGwuCgogICAgMSkgVGhlIGNoYW5nZWxvZyBpcyB3b3JkIHNhbGFkIGFuZCBwcm92aWRl cyAwIHJhdGlvbmFsZQoKICAgICAgIEFsc28gc3VjaCBzZXJpZXMgcmVxdWlyZSBhIGNvdmVyIGxl dHRlci4uLgoKICAgIDIpIFRoZSBkZXZfZXJyKCkgd2hpY2ggaXMgYWRkZWQgaXMgbm90IGluZm9y bWF0aXZlIGF0IGFsbCBhbmQgY2Fubm90CiAgICAgICByZXBsYWNlIGFjdHVhbGx5IHVzZWZ1bCBl cnJvciBtZXNzYWdlcy4gSXQncyBub3QgdGhhdCBoYXJkIHRvCiAgICAgICBtYWtlIGl0IHVzZWZ1 bC4KCiAgICAyKSBBZGRpbmcgdGhlIHByaW50a3MgdW5jb25kaXRpb25hbGx5IGZpcnN0IHdpbGwg ZW1pdCB0d28gbWVzc2FnZXMKICAgICAgIHdpdGggZGlmZmVyZW50IGNvbnRlbnQuCgogICAgICAg VGhpcyBpcyBub3QgaG93IHN1Y2ggY2hhbmdlcyBhcmUgZG9uZS4KCiAgICAgICBUaGUgcHJvcGVy IGFwcHJvYWNoIGlzIHRvIGNyZWF0ZSBhIHdyYXBwZXIgZnVuY3Rpb24gd2hpY2ggZW1pdHMKICAg ICAgIHRoZSBlcnJvciBtZXNzYWdlOgoKICAgICAgIHdyYXBwZXIoLi4uLi4sIGNvbnN0IGNoYXIg KmluZm8pCiAgICAgICB7CiAgICAgICAgICAgIHJldCA9IGRldm1fcmVxdWVzdF90aHJlYWRlZF9p cnEoLi4uLik7CiAgICAgICAgICAgIGlmIChyZXQgPCAwKSB7CiAgICAgICAgICAgICAgIGRldl9l cnIoZGV2LCAiRmFpbGVkIHRvIHJlcXVlc3QgJXNpbnRlcnJ1cHQgJXUgJXMgJXM6ICVkXG4sCiAg ICAgICAgICAgICAgICAgICAgICAgdGhyZWFkX2ZuID8gInRocmVhZGVkICIgOiAiIiwKICAgICAg ICAgICAgICAgICAgICAgICBpcnEsIGRldm5hbWUsIGluZm8gPyA6ICIiLCByZXQpOwogICAgICAg ICAgICB9CiAgICAgICAgICAgIHJldHVybiByZXQ7CiAgICAgICB9CgogICAgICAgVGhlbiBjb252 ZXJ0IHRoZSBjYWxsc2l0ZXMgb3ZlciBvbmUgYnkgb25lIHdpdGggcHJvcGVyCiAgICAgICBjaGFu Z2Vsb2dzIGFuZCBqdXN0aWZpY2F0aW9uLgoKICAgICAgIFNlZT8KClRoYW5rcywKCiAgICAgICAg dGdseAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=