From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79327C7EE24 for ; Tue, 6 Jun 2023 15:56:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4802110E378; Tue, 6 Jun 2023 15:56:49 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 742BA10E378 for ; Tue, 6 Jun 2023 15:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686067006; x=1717603006; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=OmpTrygljh/gdfiXxiPJmmGNYhM+a3iC31cNdMdWw8w=; b=KMcj4f3KhB8JUs3rvck5M5WOwDF5XbWSZ7imihA0RW9VUxmI/jOQG6hd jlebbI/VNbgMpOIdPb+y633IhUXi1T7cDKsUc1sPiPPc8b+jsWbNB54M0 QIw5sHktM4m59GIHB6RaP2dyA7Atnx1qyPZAn+xOnQHdcL7EziiMm43Cd YVh+QSi/bzl82o66JPJREFxSC+0+lljmVNfGL/udtj5xEq7OenyaANxQK Acl+R76yU00lRBCmvtgMg8AnthvWGdIgdmpUuBicp8t6GpVemXnbzEjZs YmEbYLcMMQrBIfNhL7fj1XW+6j+bisqv5EIvAwvsMLW36y2L8k4DTqCLx w==; X-IronPort-AV: E=McAfee;i="6600,9927,10733"; a="356730796" X-IronPort-AV: E=Sophos;i="6.00,221,1681196400"; d="scan'208";a="356730796" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2023 08:56:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10733"; a="779031809" X-IronPort-AV: E=Sophos;i="6.00,221,1681196400"; d="scan'208";a="779031809" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.231.30]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2023 08:56:45 -0700 Date: Tue, 06 Jun 2023 08:56:21 -0700 Message-ID: <87h6rkmvoa.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Sujaritha Sundaresan In-Reply-To: <20230606082142.7846-1-sujaritha.sundaresan@intel.com> References: <20230606082142.7846-1-sujaritha.sundaresan@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-xe] [PATCH] [RFC]drm/xe: Sysfs entries to query fused min, max frequency of lmem X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 06 Jun 2023 01:21:42 -0700, Sujaritha Sundaresan wrote: > Hi Suja, Once again sysfs_create_files is missing from the patch. Also xe calls lmem vram, so sysfs file names should something like vram_rp0/rpn_freq_mhz, "mem" is too general. Ashutosh > Signed-off-by: Sujaritha Sundaresan > --- > drivers/gpu/drm/xe/regs/xe_regs.h | 7 +++++ > drivers/gpu/drm/xe/xe_guc_pc.c | 44 +++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+) > > diff --git a/drivers/gpu/drm/xe/regs/xe_regs.h b/drivers/gpu/drm/xe/regs/xe_regs.h > index 8be616a1bd51..bd7b26296402 100644 > --- a/drivers/gpu/drm/xe/regs/xe_regs.h > +++ b/drivers/gpu/drm/xe/regs/xe_regs.h > @@ -101,4 +101,11 @@ > #define DSMBASE XE_REG(0x1080C0) > #define BDSM_MASK REG_GENMASK64(63, 20) > > +#define XEHP_PCODE_FREQUENCY_CONFIG 0x6e > +/* XEHP_PCODE_FREQUENCY_CONFIG sub-commands (param1) */ > +#define PCODE_MBOX_FC_SC_READ_FUSED_P0 0x0 > +#define PCODE_MBOX_FC_SC_READ_FUSED_PN 0x1 > +/* PCODE_MBOX_DOMAIN_* - mailbox domain IDs */ > +#define PCODE_MBOX_DOMAIN_HBM 0x2 > + > #endif > diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c > index 67faa9ee0006..1b349ce74c3d 100644 > --- a/drivers/gpu/drm/xe/xe_guc_pc.c > +++ b/drivers/gpu/drm/xe/xe_guc_pc.c > @@ -453,6 +453,48 @@ static ssize_t freq_rpn_show(struct device *dev, > } > static DEVICE_ATTR_RO(freq_rpn); > > +static ssize_t freq_mem_rp0_show(struct device *dev, > + struct device_attribute *attr, char *buff) > +{ > + struct kobject *kobj = &dev->kobj; > + struct xe_gt *gt = kobj_to_gt(kobj); > + u32 val; > + int err; > + > + err = xe_pcode_read(dev, XEHPSDV_PCODE_FREQUENCY_CONFIG, > + PCODE_MBOX_FC_SC_READ_FUSED_P0, > + PCODE_MBOX_DOMAIN_HBM, &val); > + if (err) > + return err; > + > + /* data_out - Fused P0 for domain ID in units of 50 MHz */ > + val *= GT_FREQUENCY_MULTIPLIER; > + > + return sysfs_emit(buff, "%u\n", val); > +} > +static DEVICE_ATTR_RO(freq_mem_rp0); > + > +static ssize_t freq_mem_rpn_show(struct device *dev, > + struct device_attribute *attr, char *buff) > +{ > + struct kobject *kobj = &dev->kobj; > + struct xe_gt *gt = kobj_to_gt(kobj); > + u32 val; > + int err; > + > + err = xe_pcode_read(dev, XEHPSDV_PCODE_FREQUENCY_CONFIG, > + PCODE_MBOX_FC_SC_READ_FUSED_PN, > + PCODE_MBOX_DOMAIN_HBM, &val); > + if (err) > + return err; > + > + /* data_out - Fused P0 for domain ID in units of 50 MHz */ > + val *= GT_FREQUENCY_MULTIPLIER; > + > + return sysfs_emit(buff, "%u\n", val); > +} > +static DEVICE_ATTR_RO(freq_mem_rpn); > + > static ssize_t freq_min_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > @@ -631,6 +673,8 @@ static const struct attribute *pc_attrs[] = { > &dev_attr_freq_rp0.attr, > &dev_attr_freq_rpe.attr, > &dev_attr_freq_rpn.attr, > + &dev_attr_freq_mem_rp0.attr, > + &dev_attr_freq_mem_rpn.attr, > &dev_attr_freq_min.attr, > &dev_attr_freq_max.attr, > &dev_attr_rc_status.attr, > -- > 2.39.1 >