From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DE51C7618D for ; Thu, 6 Apr 2023 07:50:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1F359827; Thu, 6 Apr 2023 09:49:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1F359827 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1680767402; bh=y3kUvH7bgoNqnEeEa1a1aeOgL6lBwBBmqMGkWMNosVI=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=vhmgr/pbSfDfaeDvx7ICQE/5yMy8HtoXleevi9taLN2/9EcUZZ86TOFAO5p4LYtBt n848t3UVVPlFo/3DbgiIjjaC/OeUe2h7/vH4OCjCFGFisgMq1CI8nB8tL02cOVFttY X3Uoob6hTBHQUSZxw/xL4PfrwBSU+LObmhO8Q6g8= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id AF25CF8013D; Thu, 6 Apr 2023 09:48:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 86059F80246; Thu, 6 Apr 2023 09:48:46 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5E24FF8013D for ; Thu, 6 Apr 2023 09:48:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5E24FF8013D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xXuiMP6t; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IvUM5jw0 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B5AD2227D5; Thu, 6 Apr 2023 07:48:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680767320; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nZatxLHq/PQvxUTvvjjQgwfTuM8zCLo8Lpiv4ofupx4=; b=xXuiMP6t0Yb4lHOBWg0Ov3pnmykw8b6ats2umzaCGXd+JgW76MA/vEqEURfI4+3vlAERqm CKmKV1/lFqAfLgF62o8Bfa5lgsyS/VhpoQFCKQTMC34CizgcHnSvcsLoFHo2ulsRWlbWTj 3PGTxs+q+aL7DATLxn76fTvpcIVueBU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680767320; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nZatxLHq/PQvxUTvvjjQgwfTuM8zCLo8Lpiv4ofupx4=; b=IvUM5jw0GRv6HPlEVRXGD/C+2+0gs3jXJ1OTEwNjXaJuOhiFKRIP/ZiliVWIySx/u21t+N iOYZhGqkRtjmtdBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A0D771351F; Thu, 6 Apr 2023 07:48:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KcnZJVh5LmS/TQAAMHmgww (envelope-from ); Thu, 06 Apr 2023 07:48:40 +0000 Date: Thu, 06 Apr 2023 09:48:40 +0200 Message-ID: <87h6ttv4br.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH] ALSA: document that struct __snd_pcm_mmap_control64 is messed up In-Reply-To: References: <20230405201219.2197759-1-oswald.buddenhagen@gmx.de> <87355dwnr8.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 4YPGJCCP6IXOSVKXBGQPB7RNEMPZZ6QR X-Message-ID-Hash: 4YPGJCCP6IXOSVKXBGQPB7RNEMPZZ6QR X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 06 Apr 2023 08:46:51 +0200, Oswald Buddenhagen wrote: > > On Thu, Apr 06, 2023 at 08:03:39AM +0200, Takashi Iwai wrote: > > On Wed, 05 Apr 2023 22:12:19 +0200, > > Oswald Buddenhagen wrote: > >> > >> I suppose this can't be changed anymore due to binary compat concerns. > > > > Yes, please check the thread at > > https://lore.kernel.org/all/29QBMJU8DE71E.2YZSH8IHT5HMH@mforney.org/ > > > >> + __pad_before_uframe __pad2; // BUG: this should have been __pad_after_uframe! > > > > Writing this alone doesn't help much. Actual help would be to mention > > that this typo is kept intentionally. > > > hmm, my thinking is that the immediate response to reading that > comment would be "so why don't you change it?!", at which point the > person would either realize by themselves that this is subject to > binary compat constraints, or would git-blame it and see the > explanation. > > anyway, my concern is keeping this *short*, so it doesn't distract. > > maybe > > // BUG: should be __pad_after_uframe, but binary compat > > would do, though obviously the grammar kinda sucks. > > the (too) long version could be > > // BUG: this should be __pad_after_uframe, but > // binary compatibility constraints prevent a fix. > > choose your death, i'll deliver it. ;-) The "BUG:" suffix should be dropped. This would catch eyes of (badly) trained kernel programmers as if it were a kernel panic message :) Also the term "binary compatibility" is ambiguous in this context -- especially because we're dealing with the code that treats the 32/64bit binary compatibility. But, yeah, I'm for that direction. thanks, Takashi