From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FC52C7619A for ; Wed, 5 Apr 2023 10:21:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C6FDA10E8B7; Wed, 5 Apr 2023 10:21:16 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECDA710E8B7 for ; Wed, 5 Apr 2023 10:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680690074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LwnbCCnkeV6p0EMxwdcDykkMOdpfLU8p8aqNhgjGBpc=; b=LvTO7wAgKWgO0JLodG7lf7I9q0KR/Bcaj8NoDnUzyBavNOkSar73pVZDMezJqxh48T3Psx Ak0h1brRaWTttX6mJpJuGl7iRV5Ph8f73Lm7b4S8nKd1aegvMPqeNvUx3ZoDwFExB0aHoI 6QPLKS/QhOEn07S/WJJNJSWAMjJERo8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-RYo82RQ3POC18bMtoZxJng-1; Wed, 05 Apr 2023 06:21:13 -0400 X-MC-Unique: RYo82RQ3POC18bMtoZxJng-1 Received: by mail-wm1-f69.google.com with SMTP id bh19-20020a05600c3d1300b003ee93fac4a9so18590708wmb.2 for ; Wed, 05 Apr 2023 03:21:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680690072; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LwnbCCnkeV6p0EMxwdcDykkMOdpfLU8p8aqNhgjGBpc=; b=2piHXjXa3NF0upbTNDdtlvcbWiznQgQulF5u5a9kjWYg8WZJjjehwgCVvRDvAMmWC0 Ap0JH/LG7DCS9KiKDsFbFhhT201PD2wt2kmAeLAWklWTNOyYc8ye/54oDsaze0IDgRPr gGo5pKlJsh0L4JDJvC0wPo/IOUlVjIhHtKCuxfrpXsFfCOczGgwgDRs2TchJ/6L0+gEb 71NcwGhATA5q+i5rRQG3GKx59LcskF6H3xNoX3kEFHtfU9Aw6PwSFjV2kNGHxr2zGOPQ V8nKmj8RuRfYhO7noT2ikfwSK/MHVjeDPynBGJ3WRy9GJKq9O7WRqQyMwgGTuPntK5J+ DbMQ== X-Gm-Message-State: AAQBX9c0C2jl6u1y2hkHbW7+HFc5EtqaAs9I5T/FC0WPNCIeGxa0pHxM 8B/7nfkObsVv2NALZkf2RgqTZ3jOI8V1tNzv9i/Am2mmAoCzoEbpRsr4KVSteTxNwMtDYMqZHWT HT4eksfmpDnXScRbPdAti7VgPScZC X-Received: by 2002:a5d:4dc3:0:b0:2cf:e3d0:2a43 with SMTP id f3-20020a5d4dc3000000b002cfe3d02a43mr3590093wru.4.1680690072796; Wed, 05 Apr 2023 03:21:12 -0700 (PDT) X-Google-Smtp-Source: AKy350ZIH4THo9EGjZAKkNBuLIQorIFwZkRC/w8hM10CIdydl5OhWOL9N0N6G0GANIOc9qFkYKffXA== X-Received: by 2002:a5d:4dc3:0:b0:2cf:e3d0:2a43 with SMTP id f3-20020a5d4dc3000000b002cfe3d02a43mr3590080wru.4.1680690072550; Wed, 05 Apr 2023 03:21:12 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id y13-20020adff14d000000b002c55306f6edsm14670568wro.54.2023.04.05.03.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 03:21:12 -0700 (PDT) From: Javier Martinez Canillas To: Daniel Vetter , DRI Development In-Reply-To: <20230404194038.472803-1-daniel.vetter@ffwll.ch> References: <20230404194038.472803-1-daniel.vetter@ffwll.ch> Date: Wed, 05 Apr 2023 12:21:11 +0200 Message-ID: <87h6tud3zc.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 1/3] drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , Daniel Vetter , Intel Graphics Development , syzbot+20dcf81733d43ddff661@syzkaller.appspotmail.com, stable@vger.kernel.org, Daniel Vetter , Daniel Vetter Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Daniel Vetter writes: > Drivers are supposed to fix this up if needed if they don't outright > reject it. Uncovered by 6c11df58fd1a ("fbmem: Check virtual screen > sizes in fb_set_var()"). > Should have a Fixes: tag ? I understand what was uncovered by that commit but it help distros to figure out if something has to be cherry-picked by them. So I believe that would be useful to have it. The patch looks good to me. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30406C7619A for ; Wed, 5 Apr 2023 10:22:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236779AbjDEKWF (ORCPT ); Wed, 5 Apr 2023 06:22:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230118AbjDEKWE (ORCPT ); Wed, 5 Apr 2023 06:22:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9EC5270C for ; Wed, 5 Apr 2023 03:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680690075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LwnbCCnkeV6p0EMxwdcDykkMOdpfLU8p8aqNhgjGBpc=; b=XawqWKddezFGGYDJzQTZYdwkwoFd5myKuQD0QWkvG1y0xUNhZMxL/PTf/OPtz5sUbYPOsG 89B03QU8BEAoa3XzKyUs8t/9cYIztRfGamkAKzD3n/5jSzOmpkKSg8QD+0po2pcrer6Kcl UX484IO66/D4hHsBpM8apsnQDUD0FCQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-W8-01QlDPRWztN8anNrEYQ-1; Wed, 05 Apr 2023 06:21:13 -0400 X-MC-Unique: W8-01QlDPRWztN8anNrEYQ-1 Received: by mail-wm1-f72.google.com with SMTP id bi27-20020a05600c3d9b00b003ef6ee937b8so13737554wmb.2 for ; Wed, 05 Apr 2023 03:21:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680690073; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LwnbCCnkeV6p0EMxwdcDykkMOdpfLU8p8aqNhgjGBpc=; b=VxIq3W5x02WOGLvmLRBBMuzt1eciFCuAN5sgvtkwuXlsMTRHISzvE+bVYeylqC9cr5 SICw90FN1DIBdL5XzY79fEZvkA1Fr9po0SPnTWAxiNJlR+xAxWtOCgwh8BHICx4PSTDd HCwp77g4gkwK56E6GU2lQ2UPfv3J7iEPomhZSMcCnvhIAZp86tAFV+OuGUnbTO1MQCgA J0g1fdhFup/vyg9LeQvwhBhb2V1XJcpjb/cYEaZq+2rYGTQ8qxQuJoywDgdD5v8Em/Cw pfNkEnzsj2vGvYOigi59MsdUON90mpu1NeqSvUEIFzCF8013gbCURvKzPo0T/BXcT5K6 wQ4Q== X-Gm-Message-State: AAQBX9fq7ruw0lF/pa2t9ck/GU+MnW8EVyfkr0uVASPxneQkKZol1cWG ceBJZDCUZwjs9QCbnftzIR7zwahurhUH4T9qxiLtNhvUDoxlRnAsoJc0XFeQjzbWfYm1meSTRWr XsR2Tft5z+aa4PFSl X-Received: by 2002:a5d:4dc3:0:b0:2cf:e3d0:2a43 with SMTP id f3-20020a5d4dc3000000b002cfe3d02a43mr3590092wru.4.1680690072796; Wed, 05 Apr 2023 03:21:12 -0700 (PDT) X-Google-Smtp-Source: AKy350ZIH4THo9EGjZAKkNBuLIQorIFwZkRC/w8hM10CIdydl5OhWOL9N0N6G0GANIOc9qFkYKffXA== X-Received: by 2002:a5d:4dc3:0:b0:2cf:e3d0:2a43 with SMTP id f3-20020a5d4dc3000000b002cfe3d02a43mr3590080wru.4.1680690072550; Wed, 05 Apr 2023 03:21:12 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id y13-20020adff14d000000b002c55306f6edsm14670568wro.54.2023.04.05.03.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 03:21:12 -0700 (PDT) From: Javier Martinez Canillas To: Daniel Vetter , DRI Development Cc: Intel Graphics Development , Daniel Vetter , syzbot+20dcf81733d43ddff661@syzkaller.appspotmail.com, stable@vger.kernel.org, Daniel Vetter , Thomas Zimmermann , Daniel Vetter Subject: Re: [PATCH 1/3] drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var In-Reply-To: <20230404194038.472803-1-daniel.vetter@ffwll.ch> References: <20230404194038.472803-1-daniel.vetter@ffwll.ch> Date: Wed, 05 Apr 2023 12:21:11 +0200 Message-ID: <87h6tud3zc.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Daniel Vetter writes: > Drivers are supposed to fix this up if needed if they don't outright > reject it. Uncovered by 6c11df58fd1a ("fbmem: Check virtual screen > sizes in fb_set_var()"). > Should have a Fixes: tag ? I understand what was uncovered by that commit but it help distros to figure out if something has to be cherry-picked by them. So I believe that would be useful to have it. The patch looks good to me. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6F42C76188 for ; Wed, 5 Apr 2023 10:21:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D9A8810E8BA; Wed, 5 Apr 2023 10:21:19 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B7CD10E8BA for ; Wed, 5 Apr 2023 10:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680690077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LwnbCCnkeV6p0EMxwdcDykkMOdpfLU8p8aqNhgjGBpc=; b=KYyFTHWtyMygPzoiW/mXglG/0x+Pyn7H2KbbfRm+djdgRzBsRAmFePMiD+WV+BoXgVPPrL Mo1rJmfuURXVV5YQU7Asy7RG42i90Gs33aOXvtRw7ZiEMJUnQombCTBy1HGKjp0RggsoPs +2KH7vyW5i7PX/YZ5yDcGALt+9X9HVY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-T1gEdUldPVWEwoUnsXu8sA-1; Wed, 05 Apr 2023 06:21:13 -0400 X-MC-Unique: T1gEdUldPVWEwoUnsXu8sA-1 Received: by mail-wr1-f71.google.com with SMTP id u27-20020adfa19b000000b002d3b9266941so4322809wru.2 for ; Wed, 05 Apr 2023 03:21:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680690073; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LwnbCCnkeV6p0EMxwdcDykkMOdpfLU8p8aqNhgjGBpc=; b=x5L5+PIjxhwMF/ow76BIQJCmFp1Qod2dUVaeoJIUOxgtc9/A7c+PMSd4j9+6H8ba9h 73CIo6DhBA0ORG1yuPZvf9reXz2FaqC5fJz7HylSPFL/pzeQWwUNKf3n1QaWKEk7nly3 nrkjx4GrlxXVNIqSta95UmQ7tHzWtN/niGiSl1fSFe3wihqNUng4cp17w/uebjUs4Ceb /APxsfJGEvlW/GL9G3Q06z2++uX3ej/Pd8+mqI9s3VHHMDT+/B36y9tZIX2HEoCPTOlr meH5dUgDeriORXCziIF8tTYeeqA1wa2UuZa3lZZtW3BmSzAnt3XD/boESY2hd5A13E+r FOvA== X-Gm-Message-State: AAQBX9d8ckFaeFx/ojkkE+ahm1kqLLbZ+wboEyv3jg0em7+2xl1pAy5T bgwfUlWQkgxunwYbAtJ1PNGnY1lruoW5NBKNJf4dSZF4PKoPN6jOr2hL1midjFpI0D70bMqnlQz nENguPpx3715bk6jGP4DXotG99gLM X-Received: by 2002:a5d:4dc3:0:b0:2cf:e3d0:2a43 with SMTP id f3-20020a5d4dc3000000b002cfe3d02a43mr3590095wru.4.1680690072796; Wed, 05 Apr 2023 03:21:12 -0700 (PDT) X-Google-Smtp-Source: AKy350ZIH4THo9EGjZAKkNBuLIQorIFwZkRC/w8hM10CIdydl5OhWOL9N0N6G0GANIOc9qFkYKffXA== X-Received: by 2002:a5d:4dc3:0:b0:2cf:e3d0:2a43 with SMTP id f3-20020a5d4dc3000000b002cfe3d02a43mr3590080wru.4.1680690072550; Wed, 05 Apr 2023 03:21:12 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id y13-20020adff14d000000b002c55306f6edsm14670568wro.54.2023.04.05.03.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 03:21:12 -0700 (PDT) From: Javier Martinez Canillas To: Daniel Vetter , DRI Development Subject: Re: [PATCH 1/3] drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var In-Reply-To: <20230404194038.472803-1-daniel.vetter@ffwll.ch> References: <20230404194038.472803-1-daniel.vetter@ffwll.ch> Date: Wed, 05 Apr 2023 12:21:11 +0200 Message-ID: <87h6tud3zc.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , Daniel Vetter , Intel Graphics Development , syzbot+20dcf81733d43ddff661@syzkaller.appspotmail.com, stable@vger.kernel.org, Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Daniel Vetter writes: > Drivers are supposed to fix this up if needed if they don't outright > reject it. Uncovered by 6c11df58fd1a ("fbmem: Check virtual screen > sizes in fb_set_var()"). > Should have a Fixes: tag ? I understand what was uncovered by that commit but it help distros to figure out if something has to be cherry-picked by them. So I believe that would be useful to have it. The patch looks good to me. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat