From: Richard Palethorpe <rpalethorpe@suse.de>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] madvise11.c:Check loadable module before rmmod
Date: Tue, 14 Mar 2023 13:10:43 +0000 [thread overview]
Message-ID: <87h6un5v0t.fsf@suse.de> (raw)
In-Reply-To: <ZBA7H+TYMN9OBzjm@yuki>
Hello,
Cyril Hrubis <chrubis@suse.cz> writes:
> Hi!
>> > Sounds like a bug that shoudl be fixed, we probably need to create two
>> > search strings, one with dashes and one with underscores and try to
>> > strstr() both.
>>
>> Could we not check kconfig for builtin modules?
>
> Are we 100% sure that the module-name always translates to
> CONFIG_MODULE_NAME?
I'm fairly sure this is not the case because I have spent quite some
time trying to match modules with their configuration parameters.
I had not considered trying that, but specifying the module names and
config parameters separately.
>
> I would say that we are a bit safer if we use the same files the rest of
> the tooling uses e.g. depmod, dracut etc.
I suppose that copying the logic from depmod would be safest.
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-03-14 13:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 14:04 [LTP] [PATCH v1] madvise11.c:Check loadable module before rmmod Wei Gao via ltp
2023-03-10 14:52 ` Cyril Hrubis
2023-03-11 2:23 ` Wei Gao via ltp
2023-03-12 0:47 ` Wei Gao via ltp
2023-03-13 8:55 ` Cyril Hrubis
2023-03-10 14:53 ` Cyril Hrubis
2023-03-11 2:35 ` Wei Gao via ltp
2023-03-11 2:33 ` [LTP] [PATCH v2] " Wei Gao via ltp
2023-03-12 0:44 ` [LTP] [PATCH v3] " Wei Gao via ltp
2023-03-13 9:19 ` Cyril Hrubis
2023-03-13 12:21 ` Wei Gao via ltp
2023-03-13 12:37 ` Cyril Hrubis
2023-03-13 13:46 ` Wei Gao via ltp
2023-03-13 14:06 ` Cyril Hrubis
2023-03-14 5:31 ` Wei Gao via ltp
2023-03-14 8:15 ` Cyril Hrubis
2023-03-14 8:49 ` Richard Palethorpe
2023-03-14 9:15 ` Cyril Hrubis
2023-03-14 13:10 ` Richard Palethorpe [this message]
2023-03-14 9:43 ` Wei Gao via ltp
2023-03-13 13:41 ` [LTP] [PATCH v4] " Wei Gao via ltp
2023-03-14 9:37 ` [LTP] [PATCH v5] " Wei Gao via ltp
2023-03-21 16:50 ` Petr Vorel
2023-03-23 9:47 ` Cyril Hrubis
2023-03-23 12:10 ` [LTP] [PATCH v6 0/2] madvise11: Check if module is loadable " Wei Gao via ltp
2023-03-23 12:10 ` [LTP] [PATCH v6 1/2] tst_kernel: Add function check if the kernel module is built-in Wei Gao via ltp
2023-03-24 5:51 ` Petr Vorel
2023-03-23 12:10 ` [LTP] [PATCH v6 2/2] madvise11: Check if module is loadable before rmmod Wei Gao via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6un5v0t.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.