From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5426AC7EE23 for ; Thu, 2 Mar 2023 00:36:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8A4E10E35A; Thu, 2 Mar 2023 00:36:27 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF2F810E35A for ; Thu, 2 Mar 2023 00:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677717386; x=1709253386; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=E2fsgg3ONOFNeK5HN+Xn2soCn6QAG3IoxydoaPcaZeI=; b=A5vzFEg8jfMdz9yQobDNaAtgzmLgqYzsEE+p4O19y7XWtPe3VKt/hUr7 ATESfozMBonXDV2WUYAYU9eFD+iqAfrzUV2+5OhcTzRML9/XoouH4G/JL WDWKlm/f1LbM2kX3E9/e3TMj9mhIbDI7uj6xZDclaup5nVqTeQMNLuRpG /LfoxVs2aAPuOUXcalP5lLDpnRb9BS4AcB8RguG4LCg3ShDpx49S8ZxBH fY3jg94eOohbUEy2CVy1zo+Jrvf4mx1K3tQ1/XqormK5vhuyxL6u3jrrX uatJErXxiF7tgez2hqRsnABPhxSDIRsfhJSUbb+dv5niZ4Mpx8N1RDUKT A==; X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="333296540" X-IronPort-AV: E=Sophos;i="5.98,226,1673942400"; d="scan'208";a="333296540" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2023 16:36:26 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="624706777" X-IronPort-AV: E=Sophos;i="5.98,226,1673942400"; d="scan'208";a="624706777" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.115.221]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2023 16:36:25 -0800 Date: Wed, 01 Mar 2023 16:36:25 -0800 Message-ID: <87h6v43s6u.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <20230228022329.3615793-5-umesh.nerlige.ramappa@intel.com> References: <20230228022329.3615793-1-umesh.nerlige.ramappa@intel.com> <20230228022329.3615793-5-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v3 4/9] drm/i915/perf: Group engines into respective OA groups X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 27 Feb 2023 18:23:24 -0800, Umesh Nerlige Ramappa wrote: > > @@ -3378,12 +3376,13 @@ void i915_oa_init_reg_state(const struct intel_context *ce, > const struct intel_engine_cs *engine) > { > struct i915_perf_stream *stream; > + struct i915_perf_group *g = engine->oa_group; > > - if (!engine_supports_oa(engine)) > + if (!g) Maybe leave the engine_supports_oa check here since the NULL oa_group check is now implemented there. Rest looks good to be overall so this is: Reviewed-by: Ashutosh Dixit