From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael Roth" <michael.roth@amd.com>,
"Thomas Huth" <thuth@redhat.com>,
qemu-block@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Beraldo Leal" <bleal@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Hanna Reitz" <hreitz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Daniel Berrange" <berrange@redhat.com>
Subject: Re: [PATCH v3 0/6] Python: Drop support for Python 3.6
Date: Tue, 21 Feb 2023 08:00:57 +0100 [thread overview]
Message-ID: <87h6vfzemu.fsf@pond.sub.org> (raw)
In-Reply-To: <20230221012456.2607692-1-jsnow@redhat.com> (John Snow's message of "Mon, 20 Feb 2023 20:24:50 -0500")
John Snow <jsnow@redhat.com> writes:
> CI: https://gitlab.com/jsnow/qemu/-/pipelines/783612696
> [Updated for v3, still all green.]
> GL: https://gitlab.com/jsnow/qemu/-/commits/python-require-37
>
> Hi, discussion about this series is ongoing. This series (v3) is not
> meant to address all of that discussion, but rather is an updated
> baseline for what we are capable of right now, today, without much
> additional engineering. It's meant to serve as a reference for further
> discussion.
Misses the RFC tag then :)
> To my knowledge, the inconveniences caused by this patchset as currently
> written are:
>
> (1) Users of CentOS 8 and OpenSUSE 15.4 would need to install an
> additional python package that will exist side-by-side with their
> base platform's Python 3.6 package.
>
> "zypper install python39" or "dnf install python38" is enough;
> configure will do the rest of the work.
>
> It's my understanding that this is largely a non-issue.
>
> (2) Due to our Sphinx plugin that imports QAPI code from the tree,
I can read this as "Due to our Sphinx plugin (which by the way imports
some QAPI code)" or as "Due to out Sphinx plugin importing QAPI code".
The former is more accurate. We need a newer Sphinx because we use a
plugin, the plugin is written in Python, so our new Python requirement
applies. Fine print: the code the plugin imports from QAPI is going to
break first.
> distro-provided versions of Sphinx that are installed and tied to
> Python 3.6 will no longer be suitable. Users may forego building
> docs or install a suitable sphinx using "pip".
>
> It's my understanding that this one is "kind of a bummer".
>
> I feel that the inconvenience caused by (1) is minimized as is possible;
> the inconvenience caused by (2) is slightly worse and I concede the
> workaround has some complexities that I would otherwise seek to avoid.
>
> As far as I am aware, the way forward is to work with Paolo to implement
> a proper venv solution for the build tree that will help mitigate the
> fallout from (2) by automating the use of a pip-provided Sphinx in the
> cases where the distro-provided version is insufficient.
So, your current plan is to rebase this series less its DO-NOT-MERGE
parts, on top of Paolo's. Correct?
> OK, seeya later!
next prev parent reply other threads:[~2023-02-21 7:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 1:24 [PATCH v3 0/6] Python: Drop support for Python 3.6 John Snow
2023-02-21 1:24 ` [PATCH v3 1/6] configure: Look for auxiliary Python installations John Snow
2023-02-21 11:03 ` Paolo Bonzini
2023-02-21 17:37 ` John Snow
2023-02-21 17:54 ` Daniel P. Berrangé
2023-02-24 18:04 ` Eric Blake
2023-02-21 1:24 ` [PATCH v3 2/6] configure: Add courtesy hint to Python version failure message John Snow
2023-02-21 7:33 ` Philippe Mathieu-Daudé
2023-02-21 11:01 ` Paolo Bonzini
2023-02-21 1:24 ` [PATCH v3 3/6] DO-NOT-MERGE: testing: Add Python >= 3.7 to Centos, OpenSuSE John Snow
2023-02-21 1:24 ` [PATCH v3 4/6] DO-NOT-MERGE: testing: add pip-installed sphinx-build to CentOS 8 John Snow
2023-02-21 1:24 ` [PATCH v3 5/6] meson: prefer 'sphinx-build' to 'sphinx-build-3' John Snow
2023-02-21 6:50 ` Markus Armbruster
2023-02-21 16:49 ` John Snow
2023-02-22 7:14 ` Markus Armbruster
2023-02-23 4:40 ` John Snow
2023-02-23 6:13 ` Markus Armbruster
2023-02-23 8:53 ` Paolo Bonzini
2023-02-21 11:31 ` Paolo Bonzini
2023-02-21 12:37 ` Paolo Bonzini
2023-02-21 16:56 ` John Snow
2023-02-21 1:24 ` [PATCH v3 6/6] Python: Drop support for Python 3.6 John Snow
2023-02-21 7:11 ` Markus Armbruster
2023-02-21 7:00 ` Markus Armbruster [this message]
2023-02-21 11:33 ` [PATCH v3 0/6] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6vfzemu.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.