From: Kurt Kanzenbach <kurt@linutronix.de>
To: Artem Chernyshev <artem.chernyshev@red-soft.ru>,
artem.chernyshev@red-soft.ru, Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH v3 2/3] net: dsa: hellcreek: Check return value
Date: Fri, 02 Dec 2022 08:54:36 +0100 [thread overview]
Message-ID: <87h6yes0jn.fsf@kurt> (raw)
In-Reply-To: <20221201140032.26746-2-artem.chernyshev@red-soft.ru>
[-- Attachment #1: Type: text/plain, Size: 391 bytes --]
On Thu Dec 01 2022, Artem Chernyshev wrote:
> Return NULL if we got unexpected value from skb_trim_rcsum()
^ pskb_trim_rcsum()
> in hellcreek_rcv()
For the next time, a change log should rather explain *why* a change is
made instead of *what* the patch is doing.
Other than that,
Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2022-12-02 7:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 14:00 [PATCH v3 1/3] net: dsa: ksz: Check return value Artem Chernyshev
2022-12-01 14:00 ` [PATCH v3 2/3] net: dsa: hellcreek: " Artem Chernyshev
2022-12-01 21:01 ` Florian Fainelli
2022-12-02 7:54 ` Kurt Kanzenbach [this message]
2022-12-01 14:00 ` [PATCH v3 3/3] net: dsa: sja1105: " Artem Chernyshev
2022-12-01 21:01 ` Florian Fainelli
2022-12-01 21:01 ` [PATCH v3 1/3] net: dsa: ksz: " Florian Fainelli
2022-12-03 5:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6yes0jn.fsf@kurt \
--to=kurt@linutronix.de \
--cc=andrew@lunn.ch \
--cc=artem.chernyshev@red-soft.ru \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.