From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B2F6C433FE for ; Wed, 16 Nov 2022 11:43:30 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4ACF4167F; Wed, 16 Nov 2022 12:42:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4ACF4167F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1668599008; bh=PkgxKwnnvkJSmtvhNIAN59XAoPiw4BWsgzA6oG9kpPc=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VscBw4pDpv7HAX2OoX6bRrxsW8xxns8VKpPT+LlEX0EHo4BfwP9nDoMxo1QGTHeoe 5uiNjLafltGRI9o0lr9eYhPXTDcSnLoJs+lnmQrgm82hOY9WyGhcEP+aoJh9KSESmK +Oeices9X7uSIIZRQbB0+Y5Zj5QS3yq1mypwcDAs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F01D0F80163; Wed, 16 Nov 2022 12:42:37 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7D301F80169; Wed, 16 Nov 2022 12:42:36 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5CC7EF800B8 for ; Wed, 16 Nov 2022 12:42:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5CC7EF800B8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="YFS8GeqU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="W/vJJMHv" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B35A71F920; Wed, 16 Nov 2022 11:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1668598949; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e5HffTtHhrbwkdEQj4qg4QLxj2EGNHbnhiHDdz7//VQ=; b=YFS8GeqUNWJiaHPp60D/DcGSrfdM/auRBLuwoQ5QNGeBnI+/jxD/Yod9hX48Wt8VvhVuvE eyNRf1FraqAwEhJ+9V8vlAjOWAO/PrtzrUmDzYMOoCSqJ7mhpQCyCY9MHlgY5EJ1p2eZca wI7SLCXPz5oOvIEMUv16F9cfd8sZSl4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1668598949; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e5HffTtHhrbwkdEQj4qg4QLxj2EGNHbnhiHDdz7//VQ=; b=W/vJJMHviYijG+0z0PhexKhL07ktI5GSon78daD3D7T2KyJviOwa10JulqXS5Bb/QUDXeg 6AeDAHpcvD5IW+CA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A445B134CE; Wed, 16 Nov 2022 11:42:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2VO0J6XMdGNicwAAMHmgww (envelope-from ); Wed, 16 Nov 2022 11:42:29 +0000 Date: Wed, 16 Nov 2022 12:42:29 +0100 Message-ID: <87h6yznn16.wl-tiwai@suse.de> From: Takashi Iwai To: Kuninori Morimoto Subject: Re: [PATCH] ALSA: pcm: avoid nused-but-set-variable warning In-Reply-To: <874juzg3kd.wl-kuninori.morimoto.gx@renesas.com> References: <874juzg3kd.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Mark Brown , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 16 Nov 2022 01:12:39 +0100, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > It will indicate below warning if W=1 was added and CONFIG_SND_DEBUG > was not set. This patch adds __maybe_unused and avoid it. > > ${LINUX}/sound/core/pcm_native.c: In function 'constrain_mask_params': > ${LINUX}/sound/core/pcm_native.c:291:25: error: variable 'old_mask' set but not used [-Werror=unused-but-set-variable] > 291 | struct snd_mask old_mask; > | ^~~~~~~~ > ${LINUX}/sound/core/pcm_native.c: In function 'constrain_interval_params': > ${LINUX}/sound/core/pcm_native.c:327:29: error: variable 'old_interval' set but not used [-Werror=unused-but-set-variable] > 327 | struct snd_interval old_interval; > | ^~~~~~~~~~~~ > ${LINUX}/sound/core/pcm_native.c: In function 'constrain_params_by_rules': > ${LINUX}/sound/core/pcm_native.c:368:29: error: variable 'old_interval' set but not used [-Werror=unused-but-set-variable] > 368 | struct snd_interval old_interval; > | ^~~~~~~~~~~~ > ${LINUX}/sound/core/pcm_native.c:367:25: error: variable 'old_mask' set but not used [-Werror=unused-but-set-variable] > 367 | struct snd_mask old_mask; > | ^~~~~~~~ > ${LINUX}/sound/core/pcm_native.c: In function 'snd_pcm_hw_params_choose': > ${LINUX}/sound/core/pcm_native.c:652:29: error: variable 'old_interval' set but not used [-Werror=unused-but-set-variable] > 652 | struct snd_interval old_interval; > | ^~~~~~~~~~~~ > ${LINUX}/sound/core/pcm_native.c:651:25: error: variable 'old_mask' set but not used [-Werror=unused-but-set-variable] > 651 | struct snd_mask old_mask; > | ^~~~~~~~ > cc1: all warnings being treated as errors > make[3]: *** [${LINUX}/scripts/Makefile.build:250: sound/core/pcm_native.o] error 1 > > Signed-off-by: Kuninori Morimoto Thanks, applied now. Takashi